Repository navigation
Runtime validation as fallback strategey - #1342
Merged
Merged
Conversation
octonato
force-pushed
the
octonato/validation-ast-runtime
branch
from
February 25, 2026 09:55
b2c9b3d to
e7bc619
Compare
octonato
force-pushed
the
octonato/validation-ast-runtime
branch
from
February 25, 2026 10:51
dd1621d to
ab80a0f
Compare
johanandren
approved these changes
Feb 25, 2026
| @Override | ||
| public String applyEvent(Event event) { | ||
| return ""; | ||
| } |
Contributor
There was a problem hiding this comment.
What's the onEvent method above (in several other invalid-classes as well)?
Contributor
Author
There was a problem hiding this comment.
I think this is garbage. I will remove it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A while ago I refactored to the compile time validation to operate on an intermediate AST.
As such we can convert compile time (annotation processor AST) and runtime (java reflection model) to this intermediate AST and then run the validations.
This allow us to run the same validation at compile time and at runtime.
The runtime is strictly speaking not necessary because the compile time will catch errors first.
However, a shared component library that have been validated and packaged using a previous SDK version won't be re-validated at compile time. With this change, such pre-compiled components will get a second validation run, at runtime.