Repository navigation
chore: Better error for unsupported optional + collection in views - #1515
Merged
octonato merged 4 commits intoApr 14, 2026
Merged
Conversation
Contributor
|
Can we do this with the compile time annotation processor? |
Contributor
Author
|
Yes we can. Now added, also covered a few more unsupported (Map data types, unsupported java.time types, |
octonato
approved these changes
Apr 14, 2026
octonato
left a comment
Contributor
There was a problem hiding this comment.
LGTM
The validation is much much more verbose than the previous impl, but much better. I'm happy we have a good friend writing all that for us.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Example:
Optional<List<...>>Also covers
List<Optional<...>>and other collection typesReferences https://github.com/lightbend/akka-runtime/issues/4932