Skip to content

chore: add 'since' to all deprecated methods - #1586

Merged
octonato merged 2 commits into
multi-agent-devfrom
octonato/add-since-in-deprecated
May 11, 2026
Merged

octonato merged 2 commits into
multi-agent-devfrom
octonato/add-since-in-deprecated

Conversation

@octonato

@octonato octonato commented May 8, 2026

Copy link
Copy Markdown
Contributor

Asked claude to generate a report of all deprecated methods and include the since field. This will help us in removing.

@johanandren johanandren left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, we should have always specified that ourselves to start with.

* @deprecated binary not supported, always returns empty. Use {@link #get(String)}.
*/
@Deprecated
@Deprecated(since = "3.6.0-M2")

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe not put the milestone in there and just say 3.6.0?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The script was identifying the which commit it was added to and then which release happened just after it. That's why 3.6.0-M2 showed up.

But agree, this one must be the not yet released 3.6.0.

I wonder if there is any lint tool to force us to include the since. I will check this as follow-up.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@johanandren, I did some basic search on ways to enforce the usage of since and all options seem too extended. Not sure if it's worth adding more plugins for something that is rather minor.

Co-authored-by: Renato Cavalcanti <renato@cavalcanti.be>
@octonato
octonato merged commit 6480910 into multi-agent-dev May 11, 2026
62 of 63 checks passed
@octonato
octonato deleted the octonato/add-since-in-deprecated branch May 11, 2026 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants