Repository navigation
chore: add 'since' to all deprecated methods - #1586
Conversation
johanandren
left a comment
There was a problem hiding this comment.
Good, we should have always specified that ourselves to start with.
| * @deprecated binary not supported, always returns empty. Use {@link #get(String)}. | ||
| */ | ||
| @Deprecated | ||
| @Deprecated(since = "3.6.0-M2") |
There was a problem hiding this comment.
Maybe not put the milestone in there and just say 3.6.0?
There was a problem hiding this comment.
The script was identifying the which commit it was added to and then which release happened just after it. That's why 3.6.0-M2 showed up.
But agree, this one must be the not yet released 3.6.0.
I wonder if there is any lint tool to force us to include the since. I will check this as follow-up.
There was a problem hiding this comment.
@johanandren, I did some basic search on ways to enforce the usage of since and all options seem too extended. Not sure if it's worth adding more plugins for something that is rather minor.
Co-authored-by: Renato Cavalcanti <renato@cavalcanti.be>
Asked claude to generate a report of all deprecated methods and include the
sincefield. This will help us in removing.