Skip to content

chore: gRPC clients config sanitization and allow service override in dev - #179

Merged
franciscolopezsancho merged 3 commits into
grpc-endpointsfrom
wip-grpc-clients-iteration2
Jan 28, 2025
Merged

franciscolopezsancho merged 3 commits into
grpc-endpointsfrom
wip-grpc-clients-iteration2

Conversation

@johanandren

@johanandren johanandren commented Jan 27, 2025 •

Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot added the documentation documentation related label Jan 27, 2025

@efgpinto efgpinto left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

// in production, we rely on DNS and service mesh transports, no overrides allowed
if (clientConfig.hasPath(clientKey.serviceName)) {
log.warn(
s"Configuration override for [${clientKey.serviceName}] found in 'application.conf'. This is not supported and is ignored.")

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good to have this warn πŸ‘

@franciscolopezsancho
franciscolopezsancho merged commit 044e9cc into grpc-endpoints Jan 28, 2025
@franciscolopezsancho
franciscolopezsancho deleted the wip-grpc-clients-iteration2 branch January 28, 2025 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation documentation related java-sdk

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants