Skip to content

chore: minor formatting and clean-up - #1860

Merged
aludwiko merged 1 commit into
evalkit-m1from
octonato/minor-clean-ups
Sep 10, 2026
Merged

aludwiko merged 1 commit into
evalkit-m1from
octonato/minor-clean-ups

Conversation

@octonato

@octonato octonato commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

No description provided.

Comment on lines +31 to +46

if (id == null || id.isBlank()) throw new IllegalArgumentException("case id required");

if (userMessage == null || userMessage.isBlank())
throw new IllegalArgumentException("userMessage required");

if (recordedCalls == null) throw new IllegalArgumentException("recordedCalls required");
if (recordedCalls.stream().anyMatch(c -> c == null))

if (recordedCalls.stream().anyMatch(Objects::isNull))
throw new IllegalArgumentException("recorded call required");

if (evaluators == null) throw new IllegalArgumentException("evaluators required");
if (evaluators.stream().anyMatch(e -> e == null))

if (evaluators.stream().anyMatch(Objects::isNull))
throw new IllegalArgumentException("evaluator required");

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just adding some air in between to let us breath and read it easily.

Comment on lines -44 to -46
public EvalCase(String id, String userMessage, List<Evaluator> evaluators) {
this(id, userMessage, List.of(), evaluators);
}

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This constructor is only used in the of below.
EvalCase.of is much convenient. We can keep only one.

@aludwiko
aludwiko merged commit 33c6091 into evalkit-m1 Sep 10, 2026
34 checks passed
@aludwiko
aludwiko deleted the octonato/minor-clean-ups branch September 10, 2026 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants