Skip to content

feat: S3-compatible endpoints for dev-mode object storage - #1870

Merged
pvlugter merged 6 commits into
mainfrom
pvlugter/s3-endpoints
Sep 24, 2026
Merged

pvlugter merged 6 commits into
mainfrom
pvlugter/s3-endpoints

Conversation

@pvlugter

Copy link
Copy Markdown
Member

Depends on:

SDK side for supporting S3-compatible endpoints for local object storage.

@github-actions github-actions Bot added the documentation documentation related label Sep 11, 2026
@octonato

Copy link
Copy Markdown
Contributor

@pvlugter, runtime 1.6.17 is released so I updated it here.

Took the liberty to change some if (cond) Some(code) else None in the SdkRunner by Option.when(cond) { code }

Comment on lines +254 to +261
val endpointUrl = if (c.hasPath("endpoint-url")) Some(c.getString("endpoint-url")) else None
val endpointUrl = Option.when(c.hasPath("endpoint-url")) {
c.getString("endpoint-url")
}
val accessStyle =
if (c.hasPath("access-style")) Some(parseDevS3AccessStyle(name, c.getString("access-style"))) else None
Option.when(c.hasPath("access-style")) {
parseDevS3AccessStyle(name, c.getString("access-style"))
}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is new code that I changed to use Option.when.

Comment on lines -248 to +249
val directory = if (c.hasPath("directory")) Some(c.getString("directory")) else None
val directory = Option.when(c.hasPath("directory")) {
c.getString("directory")
}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Old code, but now using Option.when.

Comment on lines -203 to +220
if (applicationConf.getBoolean("akka.javasdk.dev-mode.enabled")) {
Option.when(applicationConf.getBoolean("akka.javasdk.dev-mode.enabled")) {
val backofficeSettings = BackofficeSettingsLoader.loadBackofficeSettings(applicationConf)
val objectStorageBuckets =
extractDevObjectStorageBuckets(applicationConf.getConfig("akka.javasdk.dev-mode.object-storage"))
Some(
new SpiDevModeSettings(
httpPort = applicationConf.getInt("akka.javasdk.dev-mode.http-port"),
aclEnabled = applicationConf.getBoolean("akka.javasdk.dev-mode.acl.enabled"),
persistenceEnabled = applicationConf.getBoolean("akka.javasdk.dev-mode.persistence.enabled"),
serviceName = applicationConf.getString("akka.javasdk.dev-mode.service-name"),
eventingSupport = extractBrokerConfig(applicationConf.getConfig("akka.javasdk.dev-mode.eventing")),
mockedEventing = SpiMockedEventingSettings.empty,
testSetting = new SpiTestSettings(testMode = false, debugTracing = false),
selfServiceName = None,
backoffice = backofficeSettings,
objectStorageBuckets = objectStorageBuckets,
// running locally binds the configured port; only the testkit asks for an assigned one
ephemeralHttpPort = false))
} else None
new SpiDevModeSettings(
httpPort = applicationConf.getInt("akka.javasdk.dev-mode.http-port"),
aclEnabled = applicationConf.getBoolean("akka.javasdk.dev-mode.acl.enabled"),
persistenceEnabled = applicationConf.getBoolean("akka.javasdk.dev-mode.persistence.enabled"),
serviceName = applicationConf.getString("akka.javasdk.dev-mode.service-name"),
eventingSupport = extractBrokerConfig(applicationConf.getConfig("akka.javasdk.dev-mode.eventing")),
mockedEventing = SpiMockedEventingSettings.empty,
testSetting = new SpiTestSettings(testMode = false, debugTracing = false),
selfServiceName = None,
backoffice = backofficeSettings,
objectStorageBuckets = objectStorageBuckets,
// running locally binds the configured port; only the testkit asks for an assigned one
ephemeralHttpPort = false)
}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Old code, but now using Option.when.

@pvlugter
pvlugter force-pushed the pvlugter/s3-endpoints branch from ddc04b9 to 096ec81 Compare September 16, 2026 21:12
@pvlugter
pvlugter marked this pull request as ready for review September 24, 2026 05:28
@pvlugter
pvlugter merged commit 22cb310 into main Sep 24, 2026
38 checks passed
@pvlugter
pvlugter deleted the pvlugter/s3-endpoints branch September 24, 2026 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation documentation related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants