Repository navigation
feat: S3-compatible endpoints for dev-mode object storage - #1870
Merged
Merged
Conversation
Contributor
|
@pvlugter, runtime 1.6.17 is released so I updated it here. Took the liberty to change some |
octonato
reviewed
Sep 16, 2026
Comment on lines
+254
to
+261
| val endpointUrl = if (c.hasPath("endpoint-url")) Some(c.getString("endpoint-url")) else None | ||
| val endpointUrl = Option.when(c.hasPath("endpoint-url")) { | ||
| c.getString("endpoint-url") | ||
| } | ||
| val accessStyle = | ||
| if (c.hasPath("access-style")) Some(parseDevS3AccessStyle(name, c.getString("access-style"))) else None | ||
| Option.when(c.hasPath("access-style")) { | ||
| parseDevS3AccessStyle(name, c.getString("access-style")) | ||
| } |
Contributor
There was a problem hiding this comment.
This is new code that I changed to use Option.when.
Comment on lines
-248
to
+249
| val directory = if (c.hasPath("directory")) Some(c.getString("directory")) else None | ||
| val directory = Option.when(c.hasPath("directory")) { | ||
| c.getString("directory") | ||
| } |
Contributor
There was a problem hiding this comment.
Old code, but now using Option.when.
Comment on lines
-203
to
+220
| if (applicationConf.getBoolean("akka.javasdk.dev-mode.enabled")) { | ||
| Option.when(applicationConf.getBoolean("akka.javasdk.dev-mode.enabled")) { | ||
| val backofficeSettings = BackofficeSettingsLoader.loadBackofficeSettings(applicationConf) | ||
| val objectStorageBuckets = | ||
| extractDevObjectStorageBuckets(applicationConf.getConfig("akka.javasdk.dev-mode.object-storage")) | ||
| Some( | ||
| new SpiDevModeSettings( | ||
| httpPort = applicationConf.getInt("akka.javasdk.dev-mode.http-port"), | ||
| aclEnabled = applicationConf.getBoolean("akka.javasdk.dev-mode.acl.enabled"), | ||
| persistenceEnabled = applicationConf.getBoolean("akka.javasdk.dev-mode.persistence.enabled"), | ||
| serviceName = applicationConf.getString("akka.javasdk.dev-mode.service-name"), | ||
| eventingSupport = extractBrokerConfig(applicationConf.getConfig("akka.javasdk.dev-mode.eventing")), | ||
| mockedEventing = SpiMockedEventingSettings.empty, | ||
| testSetting = new SpiTestSettings(testMode = false, debugTracing = false), | ||
| selfServiceName = None, | ||
| backoffice = backofficeSettings, | ||
| objectStorageBuckets = objectStorageBuckets, | ||
| // running locally binds the configured port; only the testkit asks for an assigned one | ||
| ephemeralHttpPort = false)) | ||
| } else None | ||
| new SpiDevModeSettings( | ||
| httpPort = applicationConf.getInt("akka.javasdk.dev-mode.http-port"), | ||
| aclEnabled = applicationConf.getBoolean("akka.javasdk.dev-mode.acl.enabled"), | ||
| persistenceEnabled = applicationConf.getBoolean("akka.javasdk.dev-mode.persistence.enabled"), | ||
| serviceName = applicationConf.getString("akka.javasdk.dev-mode.service-name"), | ||
| eventingSupport = extractBrokerConfig(applicationConf.getConfig("akka.javasdk.dev-mode.eventing")), | ||
| mockedEventing = SpiMockedEventingSettings.empty, | ||
| testSetting = new SpiTestSettings(testMode = false, debugTracing = false), | ||
| selfServiceName = None, | ||
| backoffice = backofficeSettings, | ||
| objectStorageBuckets = objectStorageBuckets, | ||
| // running locally binds the configured port; only the testkit asks for an assigned one | ||
| ephemeralHttpPort = false) | ||
| } |
Contributor
There was a problem hiding this comment.
Old code, but now using Option.when.
octonato
approved these changes
Sep 16, 2026
pvlugter
force-pushed
the
pvlugter/s3-endpoints
branch
from
September 16, 2026 21:12
ddc04b9 to
096ec81
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on:
SDK side for supporting S3-compatible endpoints for local object storage.