Skip to content

feat: typed EvalCase - #1879

Merged
octonato merged 4 commits into
evalkit-m1from
5631-support-agent-complex-types-as-inputs
Sep 16, 2026
Merged

octonato merged 4 commits into
evalkit-m1from
5631-support-agent-complex-types-as-inputs

Conversation

@aludwiko

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions github-actions Bot added the documentation documentation related label Sep 14, 2026

@octonato octonato left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good

But I think Claude is writing very low-quality javadocs.

It's often revealing implementation details or giving irrelevant information, but also using somewhat convoluted sentences.

@aludwiko
aludwiko force-pushed the 5631-support-agent-complex-types-as-inputs branch from 031daf5 to 6979472 Compare September 16, 2026 07:12
@aludwiko
aludwiko requested a review from octonato September 16, 2026 08:15
Comment thread CLAUDE.md
Comment on lines +10 to +12
- Active voice with a named actor. Do not promote the receiver to subject ("the agent is sent
the input"); say who does what ("the runner sends the input to the agent"). Do not defer the
noun ("X is what ...", "what X does is ..."); name it first.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ‘

@octonato
octonato merged commit ad3a072 into evalkit-m1 Sep 16, 2026
38 checks passed
@octonato
octonato deleted the 5631-support-agent-complex-types-as-inputs branch September 16, 2026 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation documentation related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants