Repository navigation
feat: typed EvalCase - #1879
Merged
Merged
feat: typed EvalCase#1879
Conversation
octonato
reviewed
Sep 15, 2026
octonato
left a comment
Contributor
There was a problem hiding this comment.
Looking good
But I think Claude is writing very low-quality javadocs.
It's often revealing implementation details or giving irrelevant information, but also using somewhat convoluted sentences.
aludwiko
force-pushed
the
5631-support-agent-complex-types-as-inputs
branch
from
September 16, 2026 07:12
031daf5 to
6979472
Compare
octonato
reviewed
Sep 16, 2026
Comment on lines
+10
to
+12
| - Active voice with a named actor. Do not promote the receiver to subject ("the agent is sent | ||
| the input"); say who does what ("the runner sends the input to the agent"). Do not defer the | ||
| noun ("X is what ...", "what X does is ..."); name it first. |
octonato
approved these changes
Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.