Repository navigation
feat: ToolCallGuardrails on MCP tools - #1995
Conversation
f380208 to
49558b0
Compare
|
I rebased this, worth noting:
|
| origin match { | ||
| case SpiGuardrail.ToolOrigin.FunctionTool => new ToolCallGuardrail.ToolOrigin.FunctionTool() | ||
| case mcp: SpiGuardrail.ToolOrigin.RemoteMcp => new ToolCallGuardrail.ToolOrigin.RemoteMcp(mcp.endpoint) | ||
| } |
There was a problem hiding this comment.
is there a risk that we add another origin later? could be good to make it future proof like in #1997
There was a problem hiding this comment.
Unlikely, but we can always protect it
All use-for values are deprecated, for SimilarityGuard too. Remove the tests of the separate SimilarityGuard warning. List the replacements for the MCP values in the migration guide.
49558b0 to
cd000cd
Compare
|
🤖 review, judge if the suggestions are valid
|
|
🤖 Note about merge with #2041 It also replaces the tool interceptor with If
Both PRs change the tool name the hooks get for an aliased tool, and the arguments in the intent record. Document that in whichever PR lands first. |
|
@patriknw, I applied some more changes from your last reviews. |
|
Ah, I see you approved already. Fine, I will merge when green. |
Depends on https://github.com/lightbend/akka-runtime/pull/5862