Skip to content

docs: document that GR do receive binary data - #2063

Merged
octonato merged 1 commit into
mainfrom
octonato/avoid-unnecessary-decoding-sdk
Nov 2, 2026
Merged

octonato merged 1 commit into
mainfrom
octonato/avoid-unnecessary-decoding-sdk

Conversation

@octonato

Copy link
Copy Markdown
Contributor

Refs: https://github.com/lightbend/akka-runtime/pull/5922

Do not depend on runtime change, but docs will only be aligned after runtime is released. Better not to merge until runtime 1.7.3 is in Prod.

@octonato
octonato marked this pull request as draft October 13, 2026 15:35
@github-actions github-actions Bot added the documentation documentation related label Oct 13, 2026
@octonato

Copy link
Copy Markdown
Contributor Author

This one is invalid now. We do pass the bytes to the guardrail now.

@octonato octonato closed this Oct 15, 2026
@octonato octonato reopened this Oct 15, 2026
@octonato

Copy link
Copy Markdown
Contributor Author

I was mislead by my own title.
This PR is about documenting that the guardrail WILL receive the bytes.

🤦

@octonato octonato changed the title docs: document that GR do not receive binary data docs: document that GR do receive binary data Oct 15, 2026
@octonato
octonato force-pushed the octonato/avoid-unnecessary-decoding-sdk branch from 7c08553 to da98ed1 Compare October 15, 2026 09:43
@patriknw
patriknw marked this pull request as ready for review October 29, 2026 14:30
@patriknw

Copy link
Copy Markdown
Contributor

@octonato pls fix conflicts

Comment thread project/Dependencies.scala Outdated
}

val AkkaRuntimeVersion = sys.props.getOrElse("akka-runtime.version", "1.7.2")
val AkkaRuntimeVersion = sys.props.getOrElse("akka-runtime.version", "1.7.2-15-bf1be0f2-SNAPSHOT")

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

main is on 1.7.4 now

@octonato
octonato force-pushed the octonato/avoid-unnecessary-decoding-sdk branch from c01cf87 to 6768cb0 Compare November 2, 2026 16:53
@octonato

octonato commented Nov 2, 2026

Copy link
Copy Markdown
Contributor Author

Conflict fixed.
I will merge since it was already approved and this is now aligned with runtime behavior.

@octonato
octonato merged commit 2887136 into main Nov 2, 2026
38 checks passed
@octonato
octonato deleted the octonato/avoid-unnecessary-decoding-sdk branch November 2, 2026 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation documentation related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants