Repository navigation
feat: fail-modes - FailClosed and FailOpen - #2069
Merged
Merged
Conversation
Contributor
|
🤖 review Findings
Existing before this change
|
octonato
force-pushed
the
octonato/guardrail-fail-mode-sdk
branch
from
October 15, 2026 11:55
4a2e961 to
f951e52
Compare
octonato
force-pushed
the
octonato/guardrail-fail-mode-sdk
branch
from
October 19, 2026 09:33
2c06654 to
10fe69f
Compare
octonato
added a commit
that referenced
this pull request
Oct 19, 2026
Fixes round 1 F1 from the PR #2069 review: no test ran a fail-open `ToolCallGuardrail` through the runtime. - Add `ThrowingToolGuard`, a `ToolCallGuardrail` that throws from `decide`. - Configure it with `fail-mode = fail-open` for a function-tool agent and for an MCP agent. - Check in `AgentIntegrationTest` that each tool runs and that the reply holds the tool result.
Fixes round 1 F1 from the PR #2069 review: no test ran a fail-open `ToolCallGuardrail` through the runtime. - Add `ThrowingToolGuard`, a `ToolCallGuardrail` that throws from `decide`. - Configure it with `fail-mode = fail-open` for a function-tool agent and for an MCP agent. - Check in `AgentIntegrationTest` that each tool runs and that the reply holds the tool result.
octonato
force-pushed
the
octonato/guardrail-fail-mode-sdk
branch
from
October 19, 2026 09:45
24d8ee0 to
5b3fd97
Compare
Contributor
Author
|
@patriknw, review suggestions applied |
octonato
marked this pull request as ready for review
October 19, 2026 09:46
octonato
marked this pull request as draft
October 19, 2026 09:47
Contributor
Author
|
Back to draft because it's using a runtime snapshot |
octonato
marked this pull request as ready for review
October 22, 2026 07:48
Contributor
|
we'll use akka-runtime snapshot on main for a few days, until 1.7.3 is released |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on https://github.com/lightbend/akka-runtime/pull/5923