Repository navigation
feat: query params support - #263
Conversation
| * `akka.http.javadsl.model.HttpRequest` for a low level, streaming representation of the entire request | ||
| including headers. See xref:http-endpoints.adoc#_low_level_requests[] below for more details | ||
|
|
||
| === Request headers === |
There was a problem hiding this comment.
Move it here, I think this is still a basic interaction with endpoints.
There was a problem hiding this comment.
It's not what you immediately need to build a HTTP API, so I think it was good that it at least is further down the page and not before doing basics like how to return something. Maybe keep in basic block but last?
There was a problem hiding this comment.
My ordering idea was:
- basic stuff for request
- basic stuff for response
| Integer b = requestContext().queryParams().getInteger("b").get(); | ||
| Long c = requestContext().queryParams().getLong("c").get(); | ||
| return "name: " + name + ", a: " + a + ", b: " + b + ", c: " + c; | ||
| } |
| * `akka.http.javadsl.model.HttpRequest` for a low level, streaming representation of the entire request | ||
| including headers. See xref:http-endpoints.adoc#_low_level_requests[] below for more details | ||
|
|
||
| === Request headers === |
There was a problem hiding this comment.
It's not what you immediately need to build a HTTP API, so I think it was good that it at least is further down the page and not before doing basics like how to return something. Maybe keep in basic block but last?
Co-authored-by: Johan Andrén <johan@markatta.com>
|
Marking this as draft until we have updated runtime, and I really want to cut a SDK release as soon as runtime 1.4.2 is out in prod. |
johanandren
left a comment
There was a problem hiding this comment.
Looks good to go as soon as runtime can be bumped.
# Conflicts: # akka-javasdk/src/main/scala/akka/javasdk/impl/SdkRunner.scala
|
To be clear, this requires a new runtime. The runtime part is not included in 1.4.2. |
|
this should be ready for a rebase now, main has runtime 1.4.3 |
# Conflicts: # akka-javasdk/src/main/scala/akka/javasdk/impl/SdkRunner.scala
No description provided.