Repository navigation
fix: Handle nested class names in annotation processor - #603
Merged
Merged
Conversation
patriknw
commented
Jun 18, 2025
Contributor
- and cleanup doc-snippets so that it can be run and tested
* and cleanup doc-snippets so that it can be run and tested
patriknw
commented
Jun 18, 2025
| elementsPerComponentType.forEach((componentType, elements) -> { | ||
| var classNames = new ArrayList<>(elements.stream().map(element -> element.getQualifiedName().toString()).toList()); | ||
| var classNames = new ArrayList<>(elements.stream().map(element -> | ||
| processingEnv.getElementUtils().getBinaryName((TypeElement) element).toString()).toList()); |
Contributor
Author
There was a problem hiding this comment.
This is the bug fix. getQualifiedName is using . as separator, but it should be $ for our purpose of loading the class
johanandren
approved these changes
Jun 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.