Skip to content

chore: Misc cleanup - #71

Merged
aludwiko merged 2 commits into
java-spifrom
wip-rm-EventSourcedEntitiesImpl-patriknw
Dec 11, 2024
Merged

aludwiko merged 2 commits into
java-spifrom
wip-rm-EventSourcedEntitiesImpl-patriknw

Conversation

@patriknw

Copy link
Copy Markdown
Contributor
  • Remove EventSourcedEntitiesImpl
  • Remove KeyValueEntitiesImpl
  • Remove ActionsImpl
  • Collect spi descriptors in one loop
  • Remove commandId

On top of #70

*
* @deprecated not used anymore
*/
@Deprecated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just realised that I removed this in workflow without deprecation cycle.

@patriknw
patriknw force-pushed the wip-kve-spi-patriknw branch from e02cc1e to 133f262 Compare December 11, 2024 07:12
Base automatically changed from wip-kve-spi-patriknw to java-spi December 11, 2024 09:17
* Remove EventSourcedEntitiesImpl
* Remove KeyValueEntitiesImpl
* Remove ActionsImpl
* Collect spi descriptors in one loop
* Remove commandId
@patriknw
patriknw force-pushed the wip-rm-EventSourcedEntitiesImpl-patriknw branch from 07be6aa to 7ba5378 Compare December 11, 2024 12:55
@patriknw
patriknw marked this pull request as ready for review December 11, 2024 12:55
@aludwiko
aludwiko merged commit 9fb9f6d into java-spi Dec 11, 2024
@aludwiko
aludwiko deleted the wip-rm-EventSourcedEntitiesImpl-patriknw branch December 11, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants