Repository navigation
feat: workflow step annotation - #853
Conversation
aa3202b to
04abcf0
Compare
| @Target(ElementType.METHOD) | ||
| @Retention(RetentionPolicy.RUNTIME) | ||
| @Documented | ||
| public @interface WorkflowStep { |
There was a problem hiding this comment.
@ Step conflicts with akka.javasdk.workflow.Workflow.Step and @StepName is too narrow in my opinion.
There was a problem hiding this comment.
But the main goal here is to provide a name, no?
Therefore I think it makes sense to call it @StepName It's exactly about the name of the step.
There was a problem hiding this comment.
Yes, but sth tells me that we will use this annotation for other purposes later. Maybe not, that's why I'm not sure about the name.
There was a problem hiding this comment.
You mean to add some extra configuration for the step?
I was thinking about it earlier. Some settings can be added to annotations, like max retries, but not a timeout duration or a step failover. So having some settings in annotation and others in code will create confusion. Better to stick with code only.
There was a problem hiding this comment.
Ok, changed, we should mention it in the docs.
No description provided.