Repository navigation
feat: Support GPT-5 maxCompletionTokens - #897
Merged
Merged
Conversation
johanandren
approved these changes
Aug 15, 2025
johanandren
left a comment
Contributor
There was a problem hiding this comment.
LGTM (once runtime released/bumped)
patriknw
commented
Aug 15, 2025
| top-p = NaN | ||
| # Maximum number of tokens to generate (-1 for model default) | ||
| # Not supported by GPT-5, use max-completion-tokens instead. | ||
| max-tokens = -1 |
Contributor
Author
There was a problem hiding this comment.
The error message if trying to use this is pretty clear:
"Unsupported parameter: 'max_tokens' is not supported with this model. Use 'max_completion_tokens' instead.",
| base-url = "" | ||
| # Controls randomness in the model's output (0.0 to 1.0) | ||
| # Not supported by GPT-5. | ||
| temperature = NaN |
Contributor
Author
There was a problem hiding this comment.
error message if trying to use this:
"Unsupported value: 'temperature' does not support 0.8 with this model. Only the default (1) value is supported.",
| # predictable text while higher values (like 0.9) allow more creativity | ||
| # and variation. | ||
| # Not supported by GPT-5. | ||
| top-p = NaN |
patriknw
force-pushed
the
wip-gpt5-patriknw
branch
from
August 21, 2025 07:09
aaedf0b to
2979bf0
Compare
Contributor
Author
|
rebased, can be merged after validation |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #880
Requires a new runtime release with https://github.com/lightbend/kalix-runtime/pull/4142