Repository navigation
fix(specs): remove recommend query params overridden by the API - #6604
Merged
Merged
Conversation
Contributor
š„ Breaking changes detected !!Either this PR or a previous PR not released yet introduced breaking changes, be careful when merging. āļø Code generated!
š Benchmark resultsBenchmarks performed on the method using a mock server, the results might not reflect the real-world performance.
|
Collaborator
|
Hey @raed667 |
raed667
force-pushed
the
fix/recommend-overridden-params
branch
from
June 23, 2026 15:49
c3568a7 to
8271ca8
Compare
Fluf22
approved these changes
Jun 23, 2026
algolia-api-clients-automation-bot Bot
added a commit
that referenced
this pull request
Jun 23, 2026
⦠(generated) [skip ci] Co-authored-by: Raed <raed.chammam@algolia.com>
algolia-api-clients-automation-bot Bot
added a commit
to algolia/algoliasearch-client-csharp
that referenced
this pull request
Jun 23, 2026
ā¦rated) algolia/api-clients-automation#6604 Co-authored-by: algolia-api-clients-automation-bot[bot] <288895823+algolia-api-clients-automation-bot[bot]@users.noreply.github.com> Co-authored-by: Raed <raed.chammam@algolia.com>
algolia-api-clients-automation-bot Bot
added a commit
to algolia/algoliasearch-client-dart
that referenced
this pull request
Jun 23, 2026
ā¦rated) algolia/api-clients-automation#6604 Co-authored-by: algolia-api-clients-automation-bot[bot] <288895823+algolia-api-clients-automation-bot[bot]@users.noreply.github.com> Co-authored-by: Raed <raed.chammam@algolia.com>
algolia-api-clients-automation-bot Bot
added a commit
to algolia/algoliasearch-client-go
that referenced
this pull request
Jun 23, 2026
ā¦rated) algolia/api-clients-automation#6604 Co-authored-by: algolia-api-clients-automation-bot[bot] <288895823+algolia-api-clients-automation-bot[bot]@users.noreply.github.com> Co-authored-by: Raed <raed.chammam@algolia.com>
algolia-api-clients-automation-bot Bot
added a commit
to algolia/algoliasearch-client-java
that referenced
this pull request
Jun 23, 2026
ā¦rated) algolia/api-clients-automation#6604 Co-authored-by: algolia-api-clients-automation-bot[bot] <288895823+algolia-api-clients-automation-bot[bot]@users.noreply.github.com> Co-authored-by: Raed <raed.chammam@algolia.com>
algolia-api-clients-automation-bot Bot
added a commit
to algolia/algoliasearch-client-javascript
that referenced
this pull request
Jun 23, 2026
ā¦rated) algolia/api-clients-automation#6604 Co-authored-by: algolia-api-clients-automation-bot[bot] <288895823+algolia-api-clients-automation-bot[bot]@users.noreply.github.com> Co-authored-by: Raed <raed.chammam@algolia.com>
algolia-api-clients-automation-bot Bot
added a commit
to algolia/algoliasearch-client-kotlin
that referenced
this pull request
Jun 23, 2026
ā¦rated) algolia/api-clients-automation#6604 Co-authored-by: algolia-api-clients-automation-bot[bot] <288895823+algolia-api-clients-automation-bot[bot]@users.noreply.github.com> Co-authored-by: Raed <raed.chammam@algolia.com>
algolia-api-clients-automation-bot Bot
added a commit
to algolia/algoliasearch-client-php
that referenced
this pull request
Jun 23, 2026
ā¦rated) algolia/api-clients-automation#6604 Co-authored-by: algolia-api-clients-automation-bot[bot] <288895823+algolia-api-clients-automation-bot[bot]@users.noreply.github.com> Co-authored-by: Raed <raed.chammam@algolia.com>
algolia-api-clients-automation-bot Bot
added a commit
to algolia/algoliasearch-client-python
that referenced
this pull request
Jun 23, 2026
ā¦rated) algolia/api-clients-automation#6604 Co-authored-by: algolia-api-clients-automation-bot[bot] <288895823+algolia-api-clients-automation-bot[bot]@users.noreply.github.com> Co-authored-by: Raed <raed.chammam@algolia.com>
algolia-api-clients-automation-bot Bot
added a commit
to algolia/algoliasearch-client-ruby
that referenced
this pull request
Jun 23, 2026
ā¦rated) algolia/api-clients-automation#6604 Co-authored-by: algolia-api-clients-automation-bot[bot] <288895823+algolia-api-clients-automation-bot[bot]@users.noreply.github.com> Co-authored-by: Raed <raed.chammam@algolia.com>
algolia-api-clients-automation-bot Bot
added a commit
to algolia/algoliasearch-client-scala
that referenced
this pull request
Jun 23, 2026
ā¦rated) algolia/api-clients-automation#6604 Co-authored-by: algolia-api-clients-automation-bot[bot] <288895823+algolia-api-clients-automation-bot[bot]@users.noreply.github.com> Co-authored-by: Raed <raed.chammam@algolia.com>
algolia-api-clients-automation-bot Bot
added a commit
to algolia/algoliasearch-client-swift
that referenced
this pull request
Jun 23, 2026
ā¦rated) algolia/api-clients-automation#6604 Co-authored-by: algolia-api-clients-automation-bot[bot] <288895823+algolia-api-clients-automation-bot[bot]@users.noreply.github.com> Co-authored-by: Raed <raed.chammam@algolia.com>
Fluf22
added a commit
that referenced
this pull request
Jul 7, 2026
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
š§ What and Why
The Recommend API ignores a few query parameters and applies its own values instead, so listing them as configurable in the spec is misleading. This removes the ones that have no effect.
Changes included:
ranking,facetFilters, andenableABTestfromqueryParametersandfallbackParameters.enableRulesfromfallbackParameters. It stays onqueryParameters, where it's still applied.š§Ŗ Test
Validated with
redocly lint specs/recommend/spec.yml.