Skip to content

fix(specs): remove recommend query params overridden by the API - #6604

Merged
Fluf22 merged 2 commits into
mainfrom
fix/recommend-overridden-params
Jun 23, 2026
Merged

Fluf22 merged 2 commits into
mainfrom
fix/recommend-overridden-params

Conversation

@raed667

@raed667 raed667 commented Jun 23, 2026 •

Copy link
Copy Markdown
Contributor

🧭 What and Why

The Recommend API ignores a few query parameters and applies its own values instead, so listing them as configurable in the spec is misleading. This removes the ones that have no effect.

Changes included:

  • Remove ranking, facetFilters, and enableABTest from queryParameters and fallbackParameters.
  • Remove enableRules from fallbackParameters. It stays on queryParameters, where it's still applied.

🧪 Test

Validated with redocly lint specs/recommend/spec.yml.

@raed667
raed667 requested a review from a team as a code owner June 23, 2026 15:27
@raed667
raed667 requested review from Fluf22 and eric-zaharia June 23, 2026 15:27
@algolia-api-clients-automation-bot

algolia-api-clients-automation-bot Bot commented Jun 23, 2026 •

Copy link
Copy Markdown
Contributor

šŸ’„ Breaking changes detected !!

Either this PR or a previous PR not released yet introduced breaking changes, be careful when merging.
You can find the details in the 'client java@21' CI job.

āœ”ļø Code generated!

Name Link
šŸŖ“ Triggered by 46ee9a728bfd749639e0788c178a10f2bbe411e7
šŸƒ Generated commit cbc1f1c0bbd9de1639e3bb6e7ddcdf55b3921c2d
🌲 Generated branch generated/fix/recommend-overridden-params
šŸ“Š Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
javascript 2395
go 1912
php 1730
python 1303
csharp 1295
java 1124
ruby 923
swift 865
scala 23

@Fluf22

Fluf22 commented Jun 23, 2026

Copy link
Copy Markdown
Collaborator

Hey @raed667
Do you mean that whatever the API clients will send, the API will override it with another value?

@raed667
raed667 force-pushed the fix/recommend-overridden-params branch from c3568a7 to 8271ca8 Compare June 23, 2026 15:49
@Fluf22
Fluf22 merged commit 035c03e into main Jun 23, 2026
35 checks passed
@Fluf22
Fluf22 deleted the fix/recommend-overridden-params branch June 23, 2026 16:28
algolia-api-clients-automation-bot Bot added a commit that referenced this pull request Jun 23, 2026
… (generated) [skip ci]

Co-authored-by: Raed <raed.chammam@algolia.com>
algolia-api-clients-automation-bot Bot added a commit to algolia/algoliasearch-client-csharp that referenced this pull request Jun 23, 2026
…rated)

algolia/api-clients-automation#6604

Co-authored-by: algolia-api-clients-automation-bot[bot] <288895823+algolia-api-clients-automation-bot[bot]@users.noreply.github.com>
Co-authored-by: Raed <raed.chammam@algolia.com>
algolia-api-clients-automation-bot Bot added a commit to algolia/algoliasearch-client-dart that referenced this pull request Jun 23, 2026
…rated)

algolia/api-clients-automation#6604

Co-authored-by: algolia-api-clients-automation-bot[bot] <288895823+algolia-api-clients-automation-bot[bot]@users.noreply.github.com>
Co-authored-by: Raed <raed.chammam@algolia.com>
algolia-api-clients-automation-bot Bot added a commit to algolia/algoliasearch-client-go that referenced this pull request Jun 23, 2026
…rated)

algolia/api-clients-automation#6604

Co-authored-by: algolia-api-clients-automation-bot[bot] <288895823+algolia-api-clients-automation-bot[bot]@users.noreply.github.com>
Co-authored-by: Raed <raed.chammam@algolia.com>
algolia-api-clients-automation-bot Bot added a commit to algolia/algoliasearch-client-java that referenced this pull request Jun 23, 2026
…rated)

algolia/api-clients-automation#6604

Co-authored-by: algolia-api-clients-automation-bot[bot] <288895823+algolia-api-clients-automation-bot[bot]@users.noreply.github.com>
Co-authored-by: Raed <raed.chammam@algolia.com>
algolia-api-clients-automation-bot Bot added a commit to algolia/algoliasearch-client-javascript that referenced this pull request Jun 23, 2026
…rated)

algolia/api-clients-automation#6604

Co-authored-by: algolia-api-clients-automation-bot[bot] <288895823+algolia-api-clients-automation-bot[bot]@users.noreply.github.com>
Co-authored-by: Raed <raed.chammam@algolia.com>
algolia-api-clients-automation-bot Bot added a commit to algolia/algoliasearch-client-kotlin that referenced this pull request Jun 23, 2026
…rated)

algolia/api-clients-automation#6604

Co-authored-by: algolia-api-clients-automation-bot[bot] <288895823+algolia-api-clients-automation-bot[bot]@users.noreply.github.com>
Co-authored-by: Raed <raed.chammam@algolia.com>
algolia-api-clients-automation-bot Bot added a commit to algolia/algoliasearch-client-php that referenced this pull request Jun 23, 2026
…rated)

algolia/api-clients-automation#6604

Co-authored-by: algolia-api-clients-automation-bot[bot] <288895823+algolia-api-clients-automation-bot[bot]@users.noreply.github.com>
Co-authored-by: Raed <raed.chammam@algolia.com>
algolia-api-clients-automation-bot Bot added a commit to algolia/algoliasearch-client-python that referenced this pull request Jun 23, 2026
…rated)

algolia/api-clients-automation#6604

Co-authored-by: algolia-api-clients-automation-bot[bot] <288895823+algolia-api-clients-automation-bot[bot]@users.noreply.github.com>
Co-authored-by: Raed <raed.chammam@algolia.com>
algolia-api-clients-automation-bot Bot added a commit to algolia/algoliasearch-client-ruby that referenced this pull request Jun 23, 2026
…rated)

algolia/api-clients-automation#6604

Co-authored-by: algolia-api-clients-automation-bot[bot] <288895823+algolia-api-clients-automation-bot[bot]@users.noreply.github.com>
Co-authored-by: Raed <raed.chammam@algolia.com>
algolia-api-clients-automation-bot Bot added a commit to algolia/algoliasearch-client-scala that referenced this pull request Jun 23, 2026
…rated)

algolia/api-clients-automation#6604

Co-authored-by: algolia-api-clients-automation-bot[bot] <288895823+algolia-api-clients-automation-bot[bot]@users.noreply.github.com>
Co-authored-by: Raed <raed.chammam@algolia.com>
algolia-api-clients-automation-bot Bot added a commit to algolia/algoliasearch-client-swift that referenced this pull request Jun 23, 2026
…rated)

algolia/api-clients-automation#6604

Co-authored-by: algolia-api-clients-automation-bot[bot] <288895823+algolia-api-clients-automation-bot[bot]@users.noreply.github.com>
Co-authored-by: Raed <raed.chammam@algolia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants