Repository navigation
feat(specs): add decision (declared winner) to abtesting-v3 ABTest - #6732
Merged
Merged
Conversation
Adds an optional `decision` object to the abtesting-v3 ABTest schema, surfaced
on getABTest and listABTests. It reflects a declared winner and is a container
for future decision signals (e.g. Bayesian probability-to-be-better):
decision: { winnerVariantId: integer, declaredAt: string }
Present => the test has been decided; absent => no winner declared.
Regenerated the @algolia/abtesting JS client (the model only). Backed by the
server change in algolia/go#26540.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
✔️ Code generated!
📊 Benchmark resultsBenchmarks performed on the method using a mock server, the results might not reflect the real-world performance.
|
Drop the speculative language about future Bayesian signals from the decision field description. The description ships into the generated clients, so it should state what the field is, not internal roadmap intent. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
Author
|
@Fluf22 @MarioAlexandruDan could I get a review on this one please? |
Fluf22
approved these changes
Aug 11, 2026
Fluf22
enabled auto-merge (squash)
August 11, 2026 21:23
stevenMevans
approved these changes
Aug 11, 2026
algolia-api-clients-automation-bot Bot
added a commit
that referenced
this pull request
Aug 11, 2026
…6732) (generated) [skip ci] Co-authored-by: Christopher Hawke <69921547+cdhawke@users.noreply.github.com>
algolia-api-clients-automation-bot Bot
added a commit
to algolia/algoliasearch-client-csharp
that referenced
this pull request
Aug 11, 2026
…enerated) algolia/api-clients-automation#6732 Co-authored-by: algolia-api-clients-automation-bot[bot] <288895823+algolia-api-clients-automation-bot[bot]@users.noreply.github.com> Co-authored-by: Christopher Hawke <69921547+cdhawke@users.noreply.github.com>
algolia-api-clients-automation-bot Bot
added a commit
to algolia/algoliasearch-client-dart
that referenced
this pull request
Aug 11, 2026
…enerated) algolia/api-clients-automation#6732 Co-authored-by: algolia-api-clients-automation-bot[bot] <288895823+algolia-api-clients-automation-bot[bot]@users.noreply.github.com> Co-authored-by: Christopher Hawke <69921547+cdhawke@users.noreply.github.com>
algolia-api-clients-automation-bot Bot
added a commit
to algolia/algoliasearch-client-go
that referenced
this pull request
Aug 11, 2026
…enerated) algolia/api-clients-automation#6732 Co-authored-by: algolia-api-clients-automation-bot[bot] <288895823+algolia-api-clients-automation-bot[bot]@users.noreply.github.com> Co-authored-by: Christopher Hawke <69921547+cdhawke@users.noreply.github.com>
algolia-api-clients-automation-bot Bot
added a commit
to algolia/algoliasearch-client-java
that referenced
this pull request
Aug 11, 2026
…enerated) algolia/api-clients-automation#6732 Co-authored-by: algolia-api-clients-automation-bot[bot] <288895823+algolia-api-clients-automation-bot[bot]@users.noreply.github.com> Co-authored-by: Christopher Hawke <69921547+cdhawke@users.noreply.github.com>
algolia-api-clients-automation-bot Bot
added a commit
to algolia/algoliasearch-client-javascript
that referenced
this pull request
Aug 11, 2026
…enerated) algolia/api-clients-automation#6732 Co-authored-by: algolia-api-clients-automation-bot[bot] <288895823+algolia-api-clients-automation-bot[bot]@users.noreply.github.com> Co-authored-by: Christopher Hawke <69921547+cdhawke@users.noreply.github.com>
algolia-api-clients-automation-bot Bot
added a commit
to algolia/algoliasearch-client-kotlin
that referenced
this pull request
Aug 11, 2026
…enerated) algolia/api-clients-automation#6732 Co-authored-by: algolia-api-clients-automation-bot[bot] <288895823+algolia-api-clients-automation-bot[bot]@users.noreply.github.com> Co-authored-by: Christopher Hawke <69921547+cdhawke@users.noreply.github.com>
algolia-api-clients-automation-bot Bot
added a commit
to algolia/algoliasearch-client-php
that referenced
this pull request
Aug 11, 2026
…enerated) algolia/api-clients-automation#6732 Co-authored-by: algolia-api-clients-automation-bot[bot] <288895823+algolia-api-clients-automation-bot[bot]@users.noreply.github.com> Co-authored-by: Christopher Hawke <69921547+cdhawke@users.noreply.github.com>
algolia-api-clients-automation-bot Bot
added a commit
to algolia/algoliasearch-client-python
that referenced
this pull request
Aug 11, 2026
…enerated) algolia/api-clients-automation#6732 Co-authored-by: algolia-api-clients-automation-bot[bot] <288895823+algolia-api-clients-automation-bot[bot]@users.noreply.github.com> Co-authored-by: Christopher Hawke <69921547+cdhawke@users.noreply.github.com>
algolia-api-clients-automation-bot Bot
added a commit
to algolia/algoliasearch-client-ruby
that referenced
this pull request
Aug 11, 2026
…enerated) algolia/api-clients-automation#6732 Co-authored-by: algolia-api-clients-automation-bot[bot] <288895823+algolia-api-clients-automation-bot[bot]@users.noreply.github.com> Co-authored-by: Christopher Hawke <69921547+cdhawke@users.noreply.github.com>
algolia-api-clients-automation-bot Bot
added a commit
to algolia/algoliasearch-client-scala
that referenced
this pull request
Aug 11, 2026
…enerated) algolia/api-clients-automation#6732 Co-authored-by: algolia-api-clients-automation-bot[bot] <288895823+algolia-api-clients-automation-bot[bot]@users.noreply.github.com> Co-authored-by: Christopher Hawke <69921547+cdhawke@users.noreply.github.com>
algolia-api-clients-automation-bot Bot
added a commit
to algolia/algoliasearch-client-swift
that referenced
this pull request
Aug 11, 2026
…enerated) algolia/api-clients-automation#6732 Co-authored-by: algolia-api-clients-automation-bot[bot] <288895823+algolia-api-clients-automation-bot[bot]@users.noreply.github.com> Co-authored-by: Christopher Hawke <69921547+cdhawke@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Stack:
decision(declared winner) on v3 retrievaldecisionto the abtesting-v3 spec + regenerates the clientWhat
Add an optional
decisionobject to the abtesting-v3ABTestschema, so it appears ongetABTestandlistABTests:Present: the test has been decided (a winner declared). Absent: no winner declared. Modelled as an object (not a bare flag) so future decision signals, e.g. Bayesian probability-to-be-better, can join the same container, covering both frequentist and Bayesian outcomes.
Why
The decided state lives only in the abtests settings table server-side, so the dashboard otherwise needs a separate
/settingsrequest per test to know it, which is prohibitive on the list view. Surfacing it on the A/B test object lets the dashboard read it from the single retrieval call it already makes.How
Only the hand-written spec (
specs/abtesting-v3/common/schemas/ABTest.yml) is committed here; per this repo's workflow, CI regenerates the clients. Verified locally thatyarn cli generate javascript abtesting-v3produces the expectedDecisionmodel andABTest.decision?: Decisionfield.yarn cli build specs abtesting-v3passes.Dependencies
decision; it answers "is there enough data?", which is separate from "was a winner declared?". A future dashboard winner affordance can bump the regenerated@algolia/abtestingand consumedecisionthen.preview:

(this has been rolled out and is being returned by the api)