Skip to content

chore(ci): fail CI if a personal access token secret is referenced - #6919

Merged
eric-zaharia merged 5 commits into
mainfrom
chore/ban-pat-secrets
Aug 20, 2026
Merged

eric-zaharia merged 5 commits into
mainfrom
chore/ban-pat-secrets

Conversation

@eric-zaharia

@eric-zaharia eric-zaharia commented Aug 20, 2026 •

Copy link
Copy Markdown
Contributor

🧭 What and Why

🎟 JIRA Ticket: API-478

#6450 moved the workflows off the ALGOLIA_BOT_TOKEN PAT to the GitHub App token, and nothing references it anymore. This adds a CI check so it can't come back. The dead secrets themselves (ALGOLIA_BOT_TOKEN, and ALGOLIA_BOT_APP_ID, superseded by the ALGOLIA_BOT_CLIENT_ID variable) are deleted from the repository settings.

Changes included:

  • action_pins fails if secrets.ALGOLIA_BOT_TOKEN or secrets.GH_PERSONAL_ACCESS_TOKEN appears in .github, clients/*/.github or templates (.github/workflows/check.yml:687)

@algolia-api-clients-automation-bot

algolia-api-clients-automation-bot Bot commented Aug 20, 2026 •

Copy link
Copy Markdown
Contributor

✔️ Code generated!

Name Link
🪓 Triggered by 59a0e2431ef6b72e36ebec1a314d2dd88b6d872c
🍃 Generated commit 8ddf0d48832a4d2b81f5bbc8499b3b6f8a580e4d
🌲 Generated branch generated/chore/ban-pat-secrets
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
go 2450
javascript 2290
php 1611
csharp 1236
python 1215
java 1120
swift 993
ruby 960
scala 683

@aikido-pr-checks

aikido-pr-checks Bot commented Aug 20, 2026 •

Copy link
Copy Markdown

Summary by Aikido

Security Issues: 0 Quality Issues: 0 Resolved Issues: 0

⚡ Enhancements

  • Added CI scanning that blocked references to retired personal access token secrets
  • Made retired-secret checks fail when configured scan paths were unreadable

More info

@eric-zaharia
eric-zaharia marked this pull request as ready for review August 20, 2026 12:01
@eric-zaharia
eric-zaharia requested a review from a team as a code owner August 20, 2026 12:01
@eric-zaharia
eric-zaharia enabled auto-merge (squash) August 20, 2026 13:11
@eric-zaharia
eric-zaharia merged commit e4a6ab5 into main Aug 20, 2026
37 checks passed
@eric-zaharia
eric-zaharia deleted the chore/ban-pat-secrets branch August 20, 2026 14:20
algolia-api-clients-automation-bot Bot added a commit that referenced this pull request Aug 21, 2026
…6919) (generated) [skip ci]

Co-authored-by: Eric Zaharia <94015633+eric-zaharia@users.noreply.github.com>
algolia-api-clients-automation-bot Bot added a commit to algolia/algoliasearch-client-csharp that referenced this pull request Aug 21, 2026
…enerated)

algolia/api-clients-automation#6919

Co-authored-by: algolia-api-clients-automation-bot[bot] <288895823+algolia-api-clients-automation-bot[bot]@users.noreply.github.com>
Co-authored-by: Eric Zaharia <94015633+eric-zaharia@users.noreply.github.com>
algolia-api-clients-automation-bot Bot added a commit to algolia/algoliasearch-client-dart that referenced this pull request Aug 21, 2026
…enerated)

algolia/api-clients-automation#6919

Co-authored-by: algolia-api-clients-automation-bot[bot] <288895823+algolia-api-clients-automation-bot[bot]@users.noreply.github.com>
Co-authored-by: Eric Zaharia <94015633+eric-zaharia@users.noreply.github.com>
algolia-api-clients-automation-bot Bot added a commit to algolia/algoliasearch-client-go that referenced this pull request Aug 21, 2026
…enerated)

algolia/api-clients-automation#6919

Co-authored-by: algolia-api-clients-automation-bot[bot] <288895823+algolia-api-clients-automation-bot[bot]@users.noreply.github.com>
Co-authored-by: Eric Zaharia <94015633+eric-zaharia@users.noreply.github.com>
algolia-api-clients-automation-bot Bot added a commit to algolia/algoliasearch-client-java that referenced this pull request Aug 21, 2026
…enerated)

algolia/api-clients-automation#6919

Co-authored-by: algolia-api-clients-automation-bot[bot] <288895823+algolia-api-clients-automation-bot[bot]@users.noreply.github.com>
Co-authored-by: Eric Zaharia <94015633+eric-zaharia@users.noreply.github.com>
algolia-api-clients-automation-bot Bot added a commit to algolia/algoliasearch-client-javascript that referenced this pull request Aug 21, 2026
…enerated)

algolia/api-clients-automation#6919

Co-authored-by: algolia-api-clients-automation-bot[bot] <288895823+algolia-api-clients-automation-bot[bot]@users.noreply.github.com>
Co-authored-by: Eric Zaharia <94015633+eric-zaharia@users.noreply.github.com>
algolia-api-clients-automation-bot Bot added a commit to algolia/algoliasearch-client-kotlin that referenced this pull request Aug 21, 2026
…enerated)

algolia/api-clients-automation#6919

Co-authored-by: algolia-api-clients-automation-bot[bot] <288895823+algolia-api-clients-automation-bot[bot]@users.noreply.github.com>
Co-authored-by: Eric Zaharia <94015633+eric-zaharia@users.noreply.github.com>
algolia-api-clients-automation-bot Bot added a commit to algolia/algoliasearch-client-php that referenced this pull request Aug 21, 2026
…enerated)

algolia/api-clients-automation#6919

Co-authored-by: algolia-api-clients-automation-bot[bot] <288895823+algolia-api-clients-automation-bot[bot]@users.noreply.github.com>
Co-authored-by: Eric Zaharia <94015633+eric-zaharia@users.noreply.github.com>
algolia-api-clients-automation-bot Bot added a commit to algolia/algoliasearch-client-python that referenced this pull request Aug 21, 2026
…enerated)

algolia/api-clients-automation#6919

Co-authored-by: algolia-api-clients-automation-bot[bot] <288895823+algolia-api-clients-automation-bot[bot]@users.noreply.github.com>
Co-authored-by: Eric Zaharia <94015633+eric-zaharia@users.noreply.github.com>
algolia-api-clients-automation-bot Bot added a commit to algolia/algoliasearch-client-ruby that referenced this pull request Aug 21, 2026
…enerated)

algolia/api-clients-automation#6919

Co-authored-by: algolia-api-clients-automation-bot[bot] <288895823+algolia-api-clients-automation-bot[bot]@users.noreply.github.com>
Co-authored-by: Eric Zaharia <94015633+eric-zaharia@users.noreply.github.com>
algolia-api-clients-automation-bot Bot added a commit to algolia/algoliasearch-client-scala that referenced this pull request Aug 21, 2026
…enerated)

algolia/api-clients-automation#6919

Co-authored-by: algolia-api-clients-automation-bot[bot] <288895823+algolia-api-clients-automation-bot[bot]@users.noreply.github.com>
Co-authored-by: Eric Zaharia <94015633+eric-zaharia@users.noreply.github.com>
algolia-api-clients-automation-bot Bot added a commit to algolia/algoliasearch-client-swift that referenced this pull request Aug 21, 2026
…enerated)

algolia/api-clients-automation#6919

Co-authored-by: algolia-api-clients-automation-bot[bot] <288895823+algolia-api-clients-automation-bot[bot]@users.noreply.github.com>
Co-authored-by: Eric Zaharia <94015633+eric-zaharia@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants