Repository navigation
feat(specs): add user metrics to abtesting-v3 timeseries enum - #7181
Conversation
✔️ Code generated!
📊 Benchmark resultsBenchmarks performed on the method using a mock server, the results might not reflect the real-world performance.
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
| description: Metrics to retrieve, as a comma-separated list. If not specified, all metrics are returned. | ||
| style: form | ||
| explode: false |
There was a problem hiding this comment.
Hmm we need to double check what it gives after codegen
Im not sure we support that
There was a problem hiding this comment.
I checked the generated branch and the completed client CI. PHP now serializes the metric array into one value, Ruby uses CSV, and the two-metric request test passes across all 11 client languages with the comma encoded as '%2C'.
… (generated) [skip ci] Co-authored-by: Steven Evans <steven.evans@algolia.com>
…ted) algolia/api-clients-automation#7181 Co-authored-by: algolia-api-clients-automation-bot[bot] <288895823+algolia-api-clients-automation-bot[bot]@users.noreply.github.com> Co-authored-by: Steven Evans <steven.evans@algolia.com>
…ted) algolia/api-clients-automation#7181 Co-authored-by: algolia-api-clients-automation-bot[bot] <288895823+algolia-api-clients-automation-bot[bot]@users.noreply.github.com> Co-authored-by: Steven Evans <steven.evans@algolia.com>
…ted) algolia/api-clients-automation#7181 Co-authored-by: algolia-api-clients-automation-bot[bot] <288895823+algolia-api-clients-automation-bot[bot]@users.noreply.github.com> Co-authored-by: Steven Evans <steven.evans@algolia.com>
…ted) algolia/api-clients-automation#7181 Co-authored-by: algolia-api-clients-automation-bot[bot] <288895823+algolia-api-clients-automation-bot[bot]@users.noreply.github.com> Co-authored-by: Steven Evans <steven.evans@algolia.com>
…ted) algolia/api-clients-automation#7181 Co-authored-by: algolia-api-clients-automation-bot[bot] <288895823+algolia-api-clients-automation-bot[bot]@users.noreply.github.com> Co-authored-by: Steven Evans <steven.evans@algolia.com>
…ted) algolia/api-clients-automation#7181 Co-authored-by: algolia-api-clients-automation-bot[bot] <288895823+algolia-api-clients-automation-bot[bot]@users.noreply.github.com> Co-authored-by: Steven Evans <steven.evans@algolia.com>
…ted) algolia/api-clients-automation#7181 Co-authored-by: algolia-api-clients-automation-bot[bot] <288895823+algolia-api-clients-automation-bot[bot]@users.noreply.github.com> Co-authored-by: Steven Evans <steven.evans@algolia.com>
…ted) algolia/api-clients-automation#7181 Co-authored-by: algolia-api-clients-automation-bot[bot] <288895823+algolia-api-clients-automation-bot[bot]@users.noreply.github.com> Co-authored-by: Steven Evans <steven.evans@algolia.com>
…ted) algolia/api-clients-automation#7181 Co-authored-by: algolia-api-clients-automation-bot[bot] <288895823+algolia-api-clients-automation-bot[bot]@users.noreply.github.com> Co-authored-by: Steven Evans <steven.evans@algolia.com>
…ted) algolia/api-clients-automation#7181 Co-authored-by: algolia-api-clients-automation-bot[bot] <288895823+algolia-api-clients-automation-bot[bot]@users.noreply.github.com> Co-authored-by: Steven Evans <steven.evans@algolia.com>
…ted) algolia/api-clients-automation#7181 Co-authored-by: algolia-api-clients-automation-bot[bot] <288895823+algolia-api-clients-automation-bot[bot]@users.noreply.github.com> Co-authored-by: Steven Evans <steven.evans@algolia.com>
🧭 What and Why
The A/B Testing v3 timeseries
MetricNameenum is missing user metrics that the backend already supports. Generated clients therefore don't expose those values for themetricfilter. This PR keeps the enum so valid names remain discoverable, adds the missing user metrics, and makes the filter's comma-separated serialization explicit.🎟 JIRA Ticket: OPTIM-2866 & OPTIM-3156
Changes included:
MetricName, including counts, rates, per-user averages, and winsorized revenue metrics.PrimaryMetricand corrects its revenue analytics description. The correspondingEffectMetricvalues are in feat(specs): add user-level rates to the abtesting-v3 EffectMetric #7145.style: formandexplode: falseon the timeseriesmetricfilter. A CTS case checks two user rates in one comma-separated parameter, with dates for positional clients.Changelog
Adds the registered user metrics to the A/B Testing v3 timeseries metric enum and the four user rates to the Bayesian primary metric enum. The timeseries
metricfilter now sends multiple values in one comma-separated query parameter.🧪 Test
The generated diff was reviewed, and CI passed the client builds and two-metric request tests across all 11 languages.