Skip to content

feat(specs): add user metrics to abtesting-v3 timeseries enum - #7181

Merged
stevenMevans merged 5 commits into
mainfrom
feat/abtesting-v3/timeseries-metrics
Oct 28, 2026
Merged

stevenMevans merged 5 commits into
mainfrom
feat/abtesting-v3/timeseries-metrics

Conversation

@stevenMevans

@stevenMevans stevenMevans commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

🧭 What and Why

The A/B Testing v3 timeseries MetricName enum is missing user metrics that the backend already supports. Generated clients therefore don't expose those values for the metric filter. This PR keeps the enum so valid names remain discoverable, adds the missing user metrics, and makes the filter's comma-separated serialization explicit.

🎟 JIRA Ticket: OPTIM-2866 & OPTIM-3156

Changes included:

  • Adds all 16 registered user metrics to MetricName, including counts, rates, per-user averages, and winsorized revenue metrics.
  • Adds the four user rates to PrimaryMetric and corrects its revenue analytics description. The corresponding EffectMetric values are in feat(specs): add user-level rates to the abtesting-v3 EffectMetric #7145.
  • Sets style: form and explode: false on the timeseries metric filter. A CTS case checks two user rates in one comma-separated parameter, with dates for positional clients.

Changelog

Adds the registered user metrics to the A/B Testing v3 timeseries metric enum and the four user rates to the Bayesian primary metric enum. The timeseries metric filter now sends multiple values in one comma-separated query parameter.

🧪 Test

The generated diff was reviewed, and CI passed the client builds and two-metric request tests across all 11 languages.

@stevenMevans
stevenMevans requested a review from a team as a code owner October 22, 2026 16:52
@stevenMevans stevenMevans added the do not merge the pull request is not yet ready label Oct 22, 2026
@algolia-api-clients-automation-bot

algolia-api-clients-automation-bot Bot commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

✔️ Code generated!

Name Link
🪓 Triggered by 151519fa0b0504a1b0b4755d1c72e9212ef086f9
🍃 Generated commit a4aa7ae5c3b25fe012b6337bc5ca1d4292b78556
🌲 Generated branch generated/feat/abtesting-v3/timeseries-metrics
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
javascript 2207
go 2055
php 1780
java 1743
ruby 1640
csharp 1354
python 1267
swift 1060
scala 652

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-22T16:57:16.345173Z bcb0efb PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Comment on lines +15 to +17
description: Metrics to retrieve, as a comma-separated list. If not specified, all metrics are returned.
style: form
explode: false

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm we need to double check what it gives after codegen
Im not sure we support that

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked the generated branch and the completed client CI. PHP now serializes the metric array into one value, Ruby uses CSV, and the two-metric request test passes across all 11 client languages with the comma encoded as '%2C'.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@stevenMevans
stevenMevans requested a review from Fluf22 October 22, 2026 19:53
@stevenMevans stevenMevans self-assigned this Oct 28, 2026
@stevenMevans stevenMevans removed the do not merge the pull request is not yet ready label Oct 28, 2026
@stevenMevans
stevenMevans enabled auto-merge (squash) October 28, 2026 22:22
@stevenMevans
stevenMevans merged commit e7642ce into main Oct 28, 2026
38 checks passed
@stevenMevans
stevenMevans deleted the feat/abtesting-v3/timeseries-metrics branch October 28, 2026 22:43
algolia-api-clients-automation-bot Bot added a commit that referenced this pull request Oct 28, 2026
… (generated) [skip ci]

Co-authored-by: Steven Evans <steven.evans@algolia.com>
algolia-api-clients-automation-bot Bot added a commit to algolia/algoliasearch-client-csharp that referenced this pull request Oct 28, 2026
…ted)

algolia/api-clients-automation#7181

Co-authored-by: algolia-api-clients-automation-bot[bot] <288895823+algolia-api-clients-automation-bot[bot]@users.noreply.github.com>
Co-authored-by: Steven Evans <steven.evans@algolia.com>
algolia-api-clients-automation-bot Bot added a commit to algolia/algoliasearch-client-dart that referenced this pull request Oct 28, 2026
…ted)

algolia/api-clients-automation#7181

Co-authored-by: algolia-api-clients-automation-bot[bot] <288895823+algolia-api-clients-automation-bot[bot]@users.noreply.github.com>
Co-authored-by: Steven Evans <steven.evans@algolia.com>
algolia-api-clients-automation-bot Bot added a commit to algolia/algoliasearch-client-go that referenced this pull request Oct 28, 2026
…ted)

algolia/api-clients-automation#7181

Co-authored-by: algolia-api-clients-automation-bot[bot] <288895823+algolia-api-clients-automation-bot[bot]@users.noreply.github.com>
Co-authored-by: Steven Evans <steven.evans@algolia.com>
algolia-api-clients-automation-bot Bot added a commit to algolia/algoliasearch-client-java that referenced this pull request Oct 28, 2026
…ted)

algolia/api-clients-automation#7181

Co-authored-by: algolia-api-clients-automation-bot[bot] <288895823+algolia-api-clients-automation-bot[bot]@users.noreply.github.com>
Co-authored-by: Steven Evans <steven.evans@algolia.com>
algolia-api-clients-automation-bot Bot added a commit to algolia/algoliasearch-client-javascript that referenced this pull request Oct 28, 2026
…ted)

algolia/api-clients-automation#7181

Co-authored-by: algolia-api-clients-automation-bot[bot] <288895823+algolia-api-clients-automation-bot[bot]@users.noreply.github.com>
Co-authored-by: Steven Evans <steven.evans@algolia.com>
algolia-api-clients-automation-bot Bot added a commit to algolia/algoliasearch-client-kotlin that referenced this pull request Oct 28, 2026
…ted)

algolia/api-clients-automation#7181

Co-authored-by: algolia-api-clients-automation-bot[bot] <288895823+algolia-api-clients-automation-bot[bot]@users.noreply.github.com>
Co-authored-by: Steven Evans <steven.evans@algolia.com>
algolia-api-clients-automation-bot Bot added a commit to algolia/algoliasearch-client-php that referenced this pull request Oct 28, 2026
…ted)

algolia/api-clients-automation#7181

Co-authored-by: algolia-api-clients-automation-bot[bot] <288895823+algolia-api-clients-automation-bot[bot]@users.noreply.github.com>
Co-authored-by: Steven Evans <steven.evans@algolia.com>
algolia-api-clients-automation-bot Bot added a commit to algolia/algoliasearch-client-python that referenced this pull request Oct 28, 2026
…ted)

algolia/api-clients-automation#7181

Co-authored-by: algolia-api-clients-automation-bot[bot] <288895823+algolia-api-clients-automation-bot[bot]@users.noreply.github.com>
Co-authored-by: Steven Evans <steven.evans@algolia.com>
algolia-api-clients-automation-bot Bot added a commit to algolia/algoliasearch-client-ruby that referenced this pull request Oct 28, 2026
…ted)

algolia/api-clients-automation#7181

Co-authored-by: algolia-api-clients-automation-bot[bot] <288895823+algolia-api-clients-automation-bot[bot]@users.noreply.github.com>
Co-authored-by: Steven Evans <steven.evans@algolia.com>
algolia-api-clients-automation-bot Bot added a commit to algolia/algoliasearch-client-scala that referenced this pull request Oct 28, 2026
…ted)

algolia/api-clients-automation#7181

Co-authored-by: algolia-api-clients-automation-bot[bot] <288895823+algolia-api-clients-automation-bot[bot]@users.noreply.github.com>
Co-authored-by: Steven Evans <steven.evans@algolia.com>
algolia-api-clients-automation-bot Bot added a commit to algolia/algoliasearch-client-swift that referenced this pull request Oct 28, 2026
…ted)

algolia/api-clients-automation#7181

Co-authored-by: algolia-api-clients-automation-bot[bot] <288895823+algolia-api-clients-automation-bot[bot]@users.noreply.github.com>
Co-authored-by: Steven Evans <steven.evans@algolia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants