Repository navigation
feat(specs): add per-feed params to Composition run request - #7199
Merged
Merged
Conversation
Contributor
βοΈ Code generated!
π Benchmark resultsBenchmarks performed on the method using a mock server, the results might not reflect the real-world performance.
|
Add a `feeds` object to the run request so each feed of a multifeed composition can override the root params, including its own `sortBy`. Update the `sortingStrategy` and `sortBy` descriptions: sorting indices no longer need to be related to the main index, and `sortBy` is inherited by every feed on a multifeed composition.
Add a CTS case for `feeds` with a feed-level override, an empty `filters`, a feed-level `sortBy` and `feedsOrder`. Add a Go round-trip test that checks feed-level empty strings stay distinct from unset values.
ben-kalmus
force-pushed
the
benk/compositions/per-feed-params
branch
from
October 27, 2026 15:10
9e2f2ff to
4c3865e
Compare
ben-kalmus
marked this pull request as ready for review
October 27, 2026 15:43
Fluf22
previously approved these changes
Oct 27, 2026
gavinwade12
reviewed
Oct 27, 2026
gavinwade12
approved these changes
Oct 28, 2026
Fluf22
approved these changes
Oct 28, 2026
ben-kalmus
marked this pull request as draft
October 28, 2026 16:00
algolia-api-clients-automation-bot Bot
added a commit
that referenced
this pull request
Nov 3, 2026
β¦generated) [skip ci] Co-authored-by: Ben Kalmus <ben.kalmus@algolia.com>
algolia-api-clients-automation-bot Bot
added a commit
to algolia/algoliasearch-client-csharp
that referenced
this pull request
Nov 3, 2026
algolia/api-clients-automation#7199 Co-authored-by: algolia-api-clients-automation-bot[bot] <288895823+algolia-api-clients-automation-bot[bot]@users.noreply.github.com> Co-authored-by: Ben Kalmus <ben.kalmus@algolia.com>
algolia-api-clients-automation-bot Bot
added a commit
to algolia/algoliasearch-client-dart
that referenced
this pull request
Nov 3, 2026
algolia/api-clients-automation#7199 Co-authored-by: algolia-api-clients-automation-bot[bot] <288895823+algolia-api-clients-automation-bot[bot]@users.noreply.github.com> Co-authored-by: Ben Kalmus <ben.kalmus@algolia.com>
algolia-api-clients-automation-bot Bot
added a commit
to algolia/algoliasearch-client-go
that referenced
this pull request
Nov 3, 2026
algolia/api-clients-automation#7199 Co-authored-by: algolia-api-clients-automation-bot[bot] <288895823+algolia-api-clients-automation-bot[bot]@users.noreply.github.com> Co-authored-by: Ben Kalmus <ben.kalmus@algolia.com>
algolia-api-clients-automation-bot Bot
added a commit
to algolia/algoliasearch-client-java
that referenced
this pull request
Nov 3, 2026
algolia/api-clients-automation#7199 Co-authored-by: algolia-api-clients-automation-bot[bot] <288895823+algolia-api-clients-automation-bot[bot]@users.noreply.github.com> Co-authored-by: Ben Kalmus <ben.kalmus@algolia.com>
algolia-api-clients-automation-bot Bot
added a commit
to algolia/algoliasearch-client-javascript
that referenced
this pull request
Nov 3, 2026
algolia/api-clients-automation#7199 Co-authored-by: algolia-api-clients-automation-bot[bot] <288895823+algolia-api-clients-automation-bot[bot]@users.noreply.github.com> Co-authored-by: Ben Kalmus <ben.kalmus@algolia.com>
algolia-api-clients-automation-bot Bot
added a commit
to algolia/algoliasearch-client-kotlin
that referenced
this pull request
Nov 3, 2026
algolia/api-clients-automation#7199 Co-authored-by: algolia-api-clients-automation-bot[bot] <288895823+algolia-api-clients-automation-bot[bot]@users.noreply.github.com> Co-authored-by: Ben Kalmus <ben.kalmus@algolia.com>
algolia-api-clients-automation-bot Bot
added a commit
to algolia/algoliasearch-client-php
that referenced
this pull request
Nov 3, 2026
algolia/api-clients-automation#7199 Co-authored-by: algolia-api-clients-automation-bot[bot] <288895823+algolia-api-clients-automation-bot[bot]@users.noreply.github.com> Co-authored-by: Ben Kalmus <ben.kalmus@algolia.com>
algolia-api-clients-automation-bot Bot
added a commit
to algolia/algoliasearch-client-python
that referenced
this pull request
Nov 3, 2026
algolia/api-clients-automation#7199 Co-authored-by: algolia-api-clients-automation-bot[bot] <288895823+algolia-api-clients-automation-bot[bot]@users.noreply.github.com> Co-authored-by: Ben Kalmus <ben.kalmus@algolia.com>
algolia-api-clients-automation-bot Bot
added a commit
to algolia/algoliasearch-client-ruby
that referenced
this pull request
Nov 3, 2026
algolia/api-clients-automation#7199 Co-authored-by: algolia-api-clients-automation-bot[bot] <288895823+algolia-api-clients-automation-bot[bot]@users.noreply.github.com> Co-authored-by: Ben Kalmus <ben.kalmus@algolia.com>
algolia-api-clients-automation-bot Bot
added a commit
to algolia/algoliasearch-client-scala
that referenced
this pull request
Nov 3, 2026
algolia/api-clients-automation#7199 Co-authored-by: algolia-api-clients-automation-bot[bot] <288895823+algolia-api-clients-automation-bot[bot]@users.noreply.github.com> Co-authored-by: Ben Kalmus <ben.kalmus@algolia.com>
algolia-api-clients-automation-bot Bot
added a commit
to algolia/algoliasearch-client-swift
that referenced
this pull request
Nov 3, 2026
algolia/api-clients-automation#7199 Co-authored-by: algolia-api-clients-automation-bot[bot] <288895823+algolia-api-clients-automation-bot[bot]@users.noreply.github.com> Co-authored-by: Ben Kalmus <ben.kalmus@algolia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
π§ What and Why
π JIRA Ticket: https://algolia.atlassian.net/browse/CMP-990
This PR adds a per-feed
feedsobject to the run request for Multifeed compositions.Changes included:
feedsto the Composition run request body: a map of feed ID toparams.feedParams: the rootparamsminusinjectedItems,getRankingInfoandenableABTest,which are rejected at feed level.sortingStrategydescription: sorting indices no longer need to be related to the main index.sortBydescription formultifeed.feeds.Backward compatibility: the Go client diff only adds symbols (
FeedParams,FeedRequest,RequestBody.Feedsand its accessors). Existing symbols are unchanged.π§ͺ Test
yarn specs:lint specs/composition/yarn cli build specs compositionyarn cli generate go composition, then checked the generated diff for removed or renamed symbols (none).searchcase intests/CTS/requests/composition/search.json. The generated Go request test passes.go test ./tests/manual/intests/output/go.