Skip to content

feat(specs): add per-feed params to Composition run request - #7199

Merged
ben-kalmus merged 7 commits into
mainfrom
benk/compositions/per-feed-params
Nov 3, 2026
Merged

ben-kalmus merged 7 commits into
mainfrom
benk/compositions/per-feed-params

Conversation

@ben-kalmus

@ben-kalmus ben-kalmus commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

🧭 What and Why

🎟 JIRA Ticket: https://algolia.atlassian.net/browse/CMP-990

This PR adds a per-feed feeds object to the run request for Multifeed compositions.

Changes included:

  • Add feeds to the Composition run request body: a map of feed ID to params.
  • Add feedParams: the root params minus injectedItems, getRankingInfo and enableABTest,which are rejected at feed level.
  • Update the sortingStrategy description: sorting indices no longer need to be related to the main index.
  • Update the sortBy description for multifeed.
  • Add a CTS case for feeds.
  • Add a Go round-trip test that checks feed-level empty strings stay distinct from unset values.

Backward compatibility: the Go client diff only adds symbols (FeedParams, FeedRequest, RequestBody.Feeds and its accessors). Existing symbols are unchanged.

πŸ§ͺ Test

  • yarn specs:lint specs/composition/
  • yarn cli build specs composition
  • yarn cli generate go composition, then checked the generated diff for removed or renamed symbols (none).
  • CTS: new search case in tests/CTS/requests/composition/search.json. The generated Go request test passes.
  • go test ./tests/manual/ in tests/output/go.
  • CI cover.

@algolia-api-clients-automation-bot

algolia-api-clients-automation-bot Bot commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

βœ”οΈ Code generated!

Name Link
πŸͺ“ Triggered by f0f932deb3e06788372483cbb7f7ef705767f1ff
πŸƒ Generated commit 0c8151008e7d506b7bf73a79b26810826e58b942
🌲 Generated branch generated/benk/compositions/per-feed-params
πŸ“Š Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
go 2472
javascript 2074
csharp 1947
php 1581
python 1247
java 1088
ruby 884
swift 625
scala 623

@ben-kalmus ben-kalmus changed the title feat(specs/compositions): add per-feed params to composition run request feat(specs): add per-feed params to Composition run request Oct 27, 2026
Add a `feeds` object to the run request so each feed of a multifeed composition can override the root params, including its own `sortBy`.
Update the `sortingStrategy` and `sortBy` descriptions: sorting indices no longer need to be related to the main index, and `sortBy` is inherited by every feed on a multifeed composition.
Add a CTS case for `feeds` with a feed-level override, an empty `filters`, a feed-level `sortBy` and `feedsOrder`.
Add a Go round-trip test that checks feed-level empty strings stay distinct from unset values.
@ben-kalmus
ben-kalmus force-pushed the benk/compositions/per-feed-params branch from 9e2f2ff to 4c3865e Compare October 27, 2026 15:10
@ben-kalmus
ben-kalmus marked this pull request as ready for review October 27, 2026 15:43
@ben-kalmus
ben-kalmus requested review from a team as code owners October 27, 2026 15:43
Fluf22
Fluf22 previously approved these changes Oct 27, 2026
@gavinwade12
gavinwade12 requested a review from a team October 27, 2026 16:09
@gavinwade12
gavinwade12 requested a review from Fluf22 October 28, 2026 12:26
@ben-kalmus ben-kalmus added the do not merge the pull request is not yet ready label Oct 28, 2026
@ben-kalmus
ben-kalmus marked this pull request as draft October 28, 2026 16:00
@ben-kalmus
ben-kalmus marked this pull request as ready for review November 2, 2026 16:12
@ben-kalmus ben-kalmus removed the do not merge the pull request is not yet ready label Nov 2, 2026
@ben-kalmus
ben-kalmus merged commit 0a3cbbb into main Nov 3, 2026
@ben-kalmus
ben-kalmus deleted the benk/compositions/per-feed-params branch November 3, 2026 15:38
algolia-api-clients-automation-bot Bot added a commit that referenced this pull request Nov 3, 2026
…generated) [skip ci]

Co-authored-by: Ben Kalmus <ben.kalmus@algolia.com>
algolia-api-clients-automation-bot Bot added a commit to algolia/algoliasearch-client-csharp that referenced this pull request Nov 3, 2026
algolia/api-clients-automation#7199

Co-authored-by: algolia-api-clients-automation-bot[bot] <288895823+algolia-api-clients-automation-bot[bot]@users.noreply.github.com>
Co-authored-by: Ben Kalmus <ben.kalmus@algolia.com>
algolia-api-clients-automation-bot Bot added a commit to algolia/algoliasearch-client-dart that referenced this pull request Nov 3, 2026
algolia/api-clients-automation#7199

Co-authored-by: algolia-api-clients-automation-bot[bot] <288895823+algolia-api-clients-automation-bot[bot]@users.noreply.github.com>
Co-authored-by: Ben Kalmus <ben.kalmus@algolia.com>
algolia-api-clients-automation-bot Bot added a commit to algolia/algoliasearch-client-go that referenced this pull request Nov 3, 2026
algolia/api-clients-automation#7199

Co-authored-by: algolia-api-clients-automation-bot[bot] <288895823+algolia-api-clients-automation-bot[bot]@users.noreply.github.com>
Co-authored-by: Ben Kalmus <ben.kalmus@algolia.com>
algolia-api-clients-automation-bot Bot added a commit to algolia/algoliasearch-client-java that referenced this pull request Nov 3, 2026
algolia/api-clients-automation#7199

Co-authored-by: algolia-api-clients-automation-bot[bot] <288895823+algolia-api-clients-automation-bot[bot]@users.noreply.github.com>
Co-authored-by: Ben Kalmus <ben.kalmus@algolia.com>
algolia-api-clients-automation-bot Bot added a commit to algolia/algoliasearch-client-javascript that referenced this pull request Nov 3, 2026
algolia/api-clients-automation#7199

Co-authored-by: algolia-api-clients-automation-bot[bot] <288895823+algolia-api-clients-automation-bot[bot]@users.noreply.github.com>
Co-authored-by: Ben Kalmus <ben.kalmus@algolia.com>
algolia-api-clients-automation-bot Bot added a commit to algolia/algoliasearch-client-kotlin that referenced this pull request Nov 3, 2026
algolia/api-clients-automation#7199

Co-authored-by: algolia-api-clients-automation-bot[bot] <288895823+algolia-api-clients-automation-bot[bot]@users.noreply.github.com>
Co-authored-by: Ben Kalmus <ben.kalmus@algolia.com>
algolia-api-clients-automation-bot Bot added a commit to algolia/algoliasearch-client-php that referenced this pull request Nov 3, 2026
algolia/api-clients-automation#7199

Co-authored-by: algolia-api-clients-automation-bot[bot] <288895823+algolia-api-clients-automation-bot[bot]@users.noreply.github.com>
Co-authored-by: Ben Kalmus <ben.kalmus@algolia.com>
algolia-api-clients-automation-bot Bot added a commit to algolia/algoliasearch-client-python that referenced this pull request Nov 3, 2026
algolia/api-clients-automation#7199

Co-authored-by: algolia-api-clients-automation-bot[bot] <288895823+algolia-api-clients-automation-bot[bot]@users.noreply.github.com>
Co-authored-by: Ben Kalmus <ben.kalmus@algolia.com>
algolia-api-clients-automation-bot Bot added a commit to algolia/algoliasearch-client-ruby that referenced this pull request Nov 3, 2026
algolia/api-clients-automation#7199

Co-authored-by: algolia-api-clients-automation-bot[bot] <288895823+algolia-api-clients-automation-bot[bot]@users.noreply.github.com>
Co-authored-by: Ben Kalmus <ben.kalmus@algolia.com>
algolia-api-clients-automation-bot Bot added a commit to algolia/algoliasearch-client-scala that referenced this pull request Nov 3, 2026
algolia/api-clients-automation#7199

Co-authored-by: algolia-api-clients-automation-bot[bot] <288895823+algolia-api-clients-automation-bot[bot]@users.noreply.github.com>
Co-authored-by: Ben Kalmus <ben.kalmus@algolia.com>
algolia-api-clients-automation-bot Bot added a commit to algolia/algoliasearch-client-swift that referenced this pull request Nov 3, 2026
algolia/api-clients-automation#7199

Co-authored-by: algolia-api-clients-automation-bot[bot] <288895823+algolia-api-clients-automation-bot[bot]@users.noreply.github.com>
Co-authored-by: Ben Kalmus <ben.kalmus@algolia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants