Repository navigation
feat(specs): support algoliaDefined ordering in external sources - #7212
Merged
Merged
Conversation
Contributor
✔️ Code generated!
📊 Benchmark resultsBenchmarks performed on the method using a mock server, the results might not reflect the real-world performance.
|
algoliaDefined ordering in external sourcesalgoliaDefined ordering in external sources
ClaraMuller
previously requested changes
Nov 2, 2026
Contributor
There was a problem hiding this comment.
Don't document API you want to depracate.
JIRA ticket states:
Replace the
defaultordering option with thealgoliaDefinedto align with the internal changes.
| enum: ['default', 'userDefined'] | ||
| default: 'default' | ||
| description: Ordering to apply on the injected items coming from the external source. 'algoliaDefined' means the items will be ordered as they are in the index (natural relevance) in the smart group. 'default' is an alias to 'algoliaDefined'. 'userDefined' means the order in which the objectIDs are provided in the run request payload will be preserved in the smart group. | ||
| enum: ['default', 'algoliaDefined', 'userDefined'] |
Contributor
There was a problem hiding this comment.
Suggested change
| enum: ['default', 'algoliaDefined', 'userDefined'] | |
| enum: ['algoliaDefined', 'userDefined'] |
Contributor
There was a problem hiding this comment.
I believe the added test will fail if this is removed.
Contributor
Author
There was a problem hiding this comment.
As discussed, we cannot remove default from the enum yet as it will break marshalling of existing compositions with ordering set already to default. This should be done once we see the usage data.
aiordache
force-pushed
the
aiordache/algolia-defined-ordering
branch
from
November 4, 2026 13:08
750f197 to
d2cb7b9
Compare
aiordache
force-pushed
the
aiordache/algolia-defined-ordering
branch
from
November 4, 2026 13:16
d2cb7b9 to
55ba267
Compare
Signed-off-by: Anca Iordache <809903+aiordache@users.noreply.github.com>
Signed-off-by: Anca Iordache <809903+aiordache@users.noreply.github.com>
aiordache
force-pushed
the
aiordache/algolia-defined-ordering
branch
from
November 4, 2026 13:32
55ba267 to
b4e93d1
Compare
gavinwade12
approved these changes
Nov 4, 2026
aiordache
enabled auto-merge (squash)
November 4, 2026 14:20
Fluf22
approved these changes
Nov 4, 2026
algolia-api-clients-automation-bot Bot
added a commit
that referenced
this pull request
Nov 4, 2026
…7212) (generated) [skip ci] Co-authored-by: Anca Iordache <809903+aiordache@users.noreply.github.com>
algolia-api-clients-automation-bot Bot
added a commit
to algolia/algoliasearch-client-csharp
that referenced
this pull request
Nov 4, 2026
…enerated) algolia/api-clients-automation#7212 Co-authored-by: algolia-api-clients-automation-bot[bot] <288895823+algolia-api-clients-automation-bot[bot]@users.noreply.github.com> Co-authored-by: Anca Iordache <809903+aiordache@users.noreply.github.com>
algolia-api-clients-automation-bot Bot
added a commit
to algolia/algoliasearch-client-dart
that referenced
this pull request
Nov 4, 2026
…enerated) algolia/api-clients-automation#7212 Co-authored-by: algolia-api-clients-automation-bot[bot] <288895823+algolia-api-clients-automation-bot[bot]@users.noreply.github.com> Co-authored-by: Anca Iordache <809903+aiordache@users.noreply.github.com>
algolia-api-clients-automation-bot Bot
added a commit
to algolia/algoliasearch-client-go
that referenced
this pull request
Nov 4, 2026
…enerated) algolia/api-clients-automation#7212 Co-authored-by: algolia-api-clients-automation-bot[bot] <288895823+algolia-api-clients-automation-bot[bot]@users.noreply.github.com> Co-authored-by: Anca Iordache <809903+aiordache@users.noreply.github.com>
algolia-api-clients-automation-bot Bot
added a commit
to algolia/algoliasearch-client-java
that referenced
this pull request
Nov 4, 2026
…enerated) algolia/api-clients-automation#7212 Co-authored-by: algolia-api-clients-automation-bot[bot] <288895823+algolia-api-clients-automation-bot[bot]@users.noreply.github.com> Co-authored-by: Anca Iordache <809903+aiordache@users.noreply.github.com>
algolia-api-clients-automation-bot Bot
added a commit
to algolia/algoliasearch-client-javascript
that referenced
this pull request
Nov 4, 2026
…enerated) algolia/api-clients-automation#7212 Co-authored-by: algolia-api-clients-automation-bot[bot] <288895823+algolia-api-clients-automation-bot[bot]@users.noreply.github.com> Co-authored-by: Anca Iordache <809903+aiordache@users.noreply.github.com>
algolia-api-clients-automation-bot Bot
added a commit
to algolia/algoliasearch-client-kotlin
that referenced
this pull request
Nov 4, 2026
…enerated) algolia/api-clients-automation#7212 Co-authored-by: algolia-api-clients-automation-bot[bot] <288895823+algolia-api-clients-automation-bot[bot]@users.noreply.github.com> Co-authored-by: Anca Iordache <809903+aiordache@users.noreply.github.com>
algolia-api-clients-automation-bot Bot
added a commit
to algolia/algoliasearch-client-php
that referenced
this pull request
Nov 4, 2026
…enerated) algolia/api-clients-automation#7212 Co-authored-by: algolia-api-clients-automation-bot[bot] <288895823+algolia-api-clients-automation-bot[bot]@users.noreply.github.com> Co-authored-by: Anca Iordache <809903+aiordache@users.noreply.github.com>
algolia-api-clients-automation-bot Bot
added a commit
to algolia/algoliasearch-client-python
that referenced
this pull request
Nov 4, 2026
…enerated) algolia/api-clients-automation#7212 Co-authored-by: algolia-api-clients-automation-bot[bot] <288895823+algolia-api-clients-automation-bot[bot]@users.noreply.github.com> Co-authored-by: Anca Iordache <809903+aiordache@users.noreply.github.com>
algolia-api-clients-automation-bot Bot
added a commit
to algolia/algoliasearch-client-ruby
that referenced
this pull request
Nov 4, 2026
…enerated) algolia/api-clients-automation#7212 Co-authored-by: algolia-api-clients-automation-bot[bot] <288895823+algolia-api-clients-automation-bot[bot]@users.noreply.github.com> Co-authored-by: Anca Iordache <809903+aiordache@users.noreply.github.com>
algolia-api-clients-automation-bot Bot
added a commit
to algolia/algoliasearch-client-scala
that referenced
this pull request
Nov 4, 2026
…enerated) algolia/api-clients-automation#7212 Co-authored-by: algolia-api-clients-automation-bot[bot] <288895823+algolia-api-clients-automation-bot[bot]@users.noreply.github.com> Co-authored-by: Anca Iordache <809903+aiordache@users.noreply.github.com>
algolia-api-clients-automation-bot Bot
added a commit
to algolia/algoliasearch-client-swift
that referenced
this pull request
Nov 4, 2026
…enerated) algolia/api-clients-automation#7212 Co-authored-by: algolia-api-clients-automation-bot[bot] <288895823+algolia-api-clients-automation-bot[bot]@users.noreply.github.com> Co-authored-by: Anca Iordache <809903+aiordache@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
🎟 JIRA Ticket: https://algolia.atlassian.net/browse/CMP-1001
Changes included:
algoliaDefinedordering is introduced as the new default ordering for external sources.defaultis supported still.🧪 Test