Skip to content

logback-nacos.xml packagingData=true cause performance issue #12323

Closed

Description

@dingjs

Describe the bug
logback-nacos.xml packagingData=true 会影响应用本身的logback配置。 packagingData=true有较严重的性能问题,开启的话,会调用loadClass ; 如异常较多,会引发严重的锁竞争,导致系统hung住。
at org.apache.catalina.loader.WebappClassLoaderBase.loadClass(WebappClassLoaderBase.java:1119)
at ch.qos.logback.classic.spi.PackagingDataCalculator.loadClass(PackagingDataCalculator.java:204)
at ch.qos.logback.classic.spi.PackagingDataCalculator.bestEffortLoadClass(PackagingDataCalculator.java:228)
at ch.qos.logback.classic.spi.PackagingDataCalculator.computeBySTEP(PackagingDataCalculator.java:135)
at ch.qos.logback.classic.spi.PackagingDataCalculator.populateUncommonFrames(PackagingDataCalculator.java:111)
at ch.qos.logback.classic.spi.PackagingDataCalculator.populateFrames(PackagingDataCalculator.java:104)
at ch.qos.logback.classic.spi.PackagingDataCalculator.calculate(PackagingDataCalculator.java:58)
at ch.qos.logback.classic.spi.ThrowableProxy.calculatePackagingData(ThrowableProxy.java:142)
at ch.qos.logback.classic.spi.LoggingEvent.(LoggingEvent.java:122)
at ch.qos.logback.classic.Logger.buildLoggingEventAndAppend(Logger.java:419)

建议

  1. 配置为false
  2. 引用应用本身自带的logback packagingData配置

Activity

  1. KomachiSion commented on Jul 15, 2024

    @KomachiSion
    Collaborator

    这个是需要在logback的root中设置,还是在appender或logger上设置?

    如果是需要在logback的root中设置, 那不应该有nacos来修复, 因为nacos的logback配置只有appender和logger, nacos只会把appender和logger给添加到用户的logback context中,不会独立创建,需要用户在他的logback配置中的打开。

    如果是appender或logger上设置, 那么辛苦提交一个pr,进行一下设置。

  2. dingjs commented on Jul 15, 2024

    @dingjs
    ContributorAuthor

    这个是需要在logback的root中设置,还是在appender或logger上设置?

    如果是需要在logback的root中设置, 那不应该有nacos来修复, 因为nacos的logback配置只有appender和logger, nacos只会把appender和logger给添加到用户的logback context中,不会独立创建,需要用户在他的logback配置中的打开。

    如果是appender或logger上设置, 那么辛苦提交一个pr,进行一下设置。

    你好,感谢回复,这个需要在 logger-adapter-impl/logback-adapter-12/src/main/resources/nacos-logback12.xml 中修改 <configuration debug="false" scan="false" **packagingData="true"**> , 去掉 **packagingData="true"** 。 目前 packagingData="true" 的配置会”影响“应用系统自己的配置。
    我这边明天晚上提交一下PR。

  3. added 2 commits that reference this issue on Jul 15, 2024
  4. added a commit that references this issue on Jul 18, 2024
  5. added this to the 2.4.0 milestone on Jul 18, 2024
  6. KomachiSion commented on Jul 18, 2024

    @KomachiSion
    Collaborator

    pr中我看没有修改nacos-logback12.xml,是否nacos-logback12.xml中也需要移除?

  7. dingjs commented on Jul 18, 2024

    @dingjs
    ContributorAuthor

    pr中我看没有修改nacos-logback12.xml,是否nacos-logback12.xml中也需要移除?

    你好,不需要移除了,代码中强制还原为业务方自己的设置了

  8. added a commit that references this issue on Jul 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area/ClientRelated to Nacos Client SDKkind/bugCategory issues or prs related to bug.

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions