Skip to content

[Fix #14807] Clean legacy nacos-ai-prompt mirror on prompt deletion - #14828

Merged
KomachiSion merged 1 commit into
alibaba:developfrom
Sunrisea:fix/prompt-delete-legacy-mirror
Apr 2, 2026
Merged

KomachiSion merged 1 commit into
alibaba:developfrom
Sunrisea:fix/prompt-delete-legacy-mirror

Conversation

@Sunrisea

@Sunrisea Sunrisea commented Apr 1, 2026

Copy link
Copy Markdown
Contributor

Related #14807

What is the purpose of the change

When a prompt is deleted through the new lifecycle governance API, the legacy latest mirror config ({promptKey}.json in nacos-ai-prompt group) is not cleaned up. This leaves orphan configs in the legacy storage location.

Brief changelog

  • Add deleteLegacyLatestMirror to the deletePrompt flow in PromptOperationServiceImpl
  • Delete {promptKey}.json from nacos-ai-prompt group when a prompt is removed
  • Failure to delete the legacy mirror is caught and logged as a warning, does not block the main deletion

Verifying this change

This change includes unit tests:

  • testDeletePromptShouldCleanLegacyLatestMirror — verifies configOperationService.deleteConfig is called with the correct dataId/group
  • testDeletePromptShouldNotFailWhenLegacyMirrorDeleteThrows — verifies deletion completes even when legacy mirror cleanup throws an exception

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check spotbugs:check -DskipTests to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

- Add deleteLegacyLatestMirror to deletePrompt flow
- Delete {promptKey}.json from nacos-ai-prompt group when prompt is removed
- Failure to delete legacy mirror does not block main deletion
- Add unit tests for legacy mirror cleanup and error tolerance
@github-actions

github-actions Bot commented Apr 1, 2026

Copy link
Copy Markdown

Thanks for your this PR. 🙏
Please check again for your PR changes whether contains any usage/api/configuration change such as Add new API , Add new configuration, Change default value of configuration.
If so, please add or update documents(markdown type) in docs/next/ for repository nacos-group/nacos-group.github.io


感谢您提交的PR。 🙏
请再次查看您的PR内容,确认是否包含任何使用方式/API/配置参数的变更,如:新增API、新增配置参数、修改默认配置等操作。
如果是,请确保在提交之前,在仓库nacos-group/nacos-group.github.io中的docs/next/目录下添加或更新文档(markdown格式)。

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@KomachiSion
KomachiSion merged commit 771ab2a into alibaba:develop Apr 2, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants