Repository navigation
test(api): complete valid clusterName TODO in NamingUtilsTest(#14865) - #14866
Merged
Merged
Conversation
|
Thanks for your this PR. 🙏 感谢您提交的PR。 🙏 |
Collaborator
|
@Sunwenzhi58 Please fix your git commit with github id and github email. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
KomachiSion
approved these changes
Apr 8, 2026
Closed
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR completes and refines the TODO section for the valid clusterName path in
NamingUtilsTest#testBatchCheckInstanceIsLegal.Related Issue
Closes #
Test Plan
mvn -pl api -Dtest=NamingUtilsTest test