Skip to content

test(api): complete valid clusterName TODO in NamingUtilsTest(#14865) - #14866

Merged
KomachiSion merged 1 commit into
alibaba:developfrom
Wz58luck:develop
Apr 8, 2026
Merged

KomachiSion merged 1 commit into
alibaba:developfrom
Wz58luck:develop

Conversation

@Wz58luck

@Wz58luck Wz58luck commented Apr 6, 2026

Copy link
Copy Markdown
Contributor

Summary

This PR completes and refines the TODO section for the valid clusterName path in NamingUtilsTest#testBatchCheckInstanceIsLegal.

  • Updated test assertion style for clarity
  • No production code changes
  • Behavior remains unchanged

Related Issue

Closes #

Test Plan

  • Run mvn -pl api -Dtest=NamingUtilsTest test
  • Ensure all updated assertions pass

@CLAassistant

CLAassistant commented Apr 6, 2026 •

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@github-actions

github-actions Bot commented Apr 6, 2026

Copy link
Copy Markdown

Thanks for your this PR. 🙏
Please check again for your PR changes whether contains any usage/api/configuration change such as Add new API , Add new configuration, Change default value of configuration.
If so, please add or update documents(markdown type) in docs/next/ for repository nacos-group/nacos-group.github.io


感谢您提交的PR。 🙏
请再次查看您的PR内容,确认是否包含任何使用方式/API/配置参数的变更,如:新增API、新增配置参数、修改默认配置等操作。
如果是,请确保在提交之前,在仓库nacos-group/nacos-group.github.io中的docs/next/目录下添加或更新文档(markdown格式)。

@KomachiSion

Copy link
Copy Markdown
Collaborator

@Sunwenzhi58 Please fix your git commit with github id and github email.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@KomachiSion
KomachiSion merged commit dd11fb6 into alibaba:develop Apr 8, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Test] Add missing remote scenario tests in NamingSubscriberServiceAggregationImplTest

4 participants