Skip to content

[ISSUE #14695] Support tagv2 gray rules - #15255

Merged
KomachiSion merged 1 commit into
alibaba:developfrom
shiyiyue1102:codex/sync-tagv2-gray-rule-14695
May 27, 2026
Merged

KomachiSion merged 1 commit into
alibaba:developfrom
shiyiyue1102:codex/sync-tagv2-gray-rule-14695

Conversation

@shiyiyue1102

Copy link
Copy Markdown
Collaborator

What is the purpose of the change

Closes #14695.

This PR syncs the existing internal Nacos tagv2 gray rule implementation into the open-source config module, so the open-source and internal branches keep the same gray rule model and behavior.

This change keeps the query path compatible with the current open-source request model. It does not add HTTP request label query support in this PR; SDK/gRPC labels continue to flow through the existing connection labels path.

Brief changelog

  • Add tagv2 single-tag and multi-tag GrayRule implementations with SPI registration.
  • Expose v3 admin gray config APIs for publish, query and delete.
  • Reuse ConfigOperationService.publishConfigGray from the v3 admin controller.
  • Add unit tests for tagv2 rule matching, SPI construction and v3 gray admin endpoints.

Verifying this change

  • ./mvnw -pl config -am -Dtest=SingleTagMatchGrayRuleTest,MultiTagMatchGrayRuleTest,GrayRuleManagerTest,ConfigControllerV3Test -Dsurefire.failIfNoSpecifiedTests=false test

KomachiSion
KomachiSion previously approved these changes May 26, 2026
@shiyiyue1102
shiyiyue1102 force-pushed the codex/sync-tagv2-gray-rule-14695 branch from 537cc73 to 67496b5 Compare May 26, 2026 10:58
@shiyiyue1102
shiyiyue1102 changed the base branch from master to develop May 26, 2026 10:58
@shiyiyue1102
shiyiyue1102 dismissed KomachiSion’s stale review May 26, 2026 10:58

The base branch was changed.

@shiyiyue1102
shiyiyue1102 force-pushed the codex/sync-tagv2-gray-rule-14695 branch from 67496b5 to eb2d845 Compare May 26, 2026 11:05
@shiyiyue1102

Copy link
Copy Markdown
Collaborator Author

@KiteSoar CLA is green and this PR is ready for review. Could you take a look when convenient?

@shiyiyue1102

Copy link
Copy Markdown
Collaborator Author

@KomachiSion CLA is green and this PR is ready for review. Could you take a look when convenient?

@KomachiSion

Copy link
Copy Markdown
Collaborator

reopen for ci

@KomachiSion KomachiSion reopened this May 27, 2026
@github-actions

Copy link
Copy Markdown

Thanks for your this PR. 🙏
Please check again for your PR changes whether contains any usage/api/configuration change such as Add new API , Add new configuration, Change default value of configuration.
If so, please add or update documents(markdown type) in docs/next/ for repository nacos-group/nacos-group.github.io


感谢您提交的PR。 🙏
请再次查看您的PR内容,确认是否包含任何使用方式/API/配置参数的变更,如:新增API、新增配置参数、修改默认配置等操作。
如果是,请确保在提交之前,在仓库nacos-group/nacos-group.github.io中的docs/next/目录下添加或更新文档(markdown格式)。

@shiyiyue1102
shiyiyue1102 force-pushed the codex/sync-tagv2-gray-rule-14695 branch from eb2d845 to 0663ec8 Compare May 27, 2026 01:47
Change-Id: I61ec478a5e7bc825858ad520159a706f8db4921f
@shiyiyue1102
shiyiyue1102 force-pushed the codex/sync-tagv2-gray-rule-14695 branch from 0663ec8 to 20c88a5 Compare May 27, 2026 02:03
@codecov-commenter

Copy link
Copy Markdown

@KomachiSion
KomachiSion merged commit f2ec3de into alibaba:develop May 27, 2026
6 checks passed
@KomachiSion KomachiSion added area/Config kind/enhancement Category issues or prs related to enhancement. labels May 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/Config kind/enhancement Category issues or prs related to enhancement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

配置中心灰度规则扩展讨论:支持基于 labels 的通用匹配能力

3 participants