Skip to content

[ISSUE #14466] Add JSON adapter selection diagnostics - #15434

Merged
KomachiSion merged 1 commit into
alibaba:developfrom
KomachiSion:codex/jackson-adapter-final-cleanup
Jun 26, 2026
Merged

KomachiSion merged 1 commit into
alibaba:developfrom
KomachiSion:codex/jackson-adapter-final-cleanup

Conversation

@KomachiSion

Copy link
Copy Markdown
Collaborator

What is the purpose of the change

Add a lightweight diagnostic log for the JSON adapter selected by the client runtime, and remove the temporary Jackson adapter migration TODO tracker after the staged work has been completed.

Brief changelog

  • Add JsonAdapterLogUtils in common to log the selected JSON adapter once per JVM.
  • Invoke the log helper from client and maintainer-client serialization initialization paths.
  • Add unit coverage for auto and explicit Jackson adapter selection logging.
  • Remove docs/jackson-json-adapter-migration-todo.md.

Verifying this change

  • mvn -pl common,client,maintainer-client spotless:apply
  • mvn -pl common,client,maintainer-client spotless:check
  • mvn -pl common -am -Dtest=JsonAdapterLogUtilsTest -Dsurefire.failIfNoSpecifiedTests=false test
  • mvn -pl client -am -Dtest=PreInitUtilsTest,InitUtilsTest -Dsurefire.failIfNoSpecifiedTests=false test
  • mvn -pl maintainer-client -am -Dtest=ParamUtilTest -Dsurefire.failIfNoSpecifiedTests=false test
  • mvn -pl common,client,maintainer-client apache-rat:check

Log the selected JSON adapter once during client and maintainer-client initialization, then remove the temporary migration tracker document.

Assisted-by: Claude Code
@github-actions

Copy link
Copy Markdown

Thanks for your this PR. 🙏
Please check again for your PR changes whether contains any usage/api/configuration change such as Add new API , Add new configuration, Change default value of configuration.
If so, please add or update documents(markdown type) in docs/next/ for repository nacos-group/nacos-group.github.io


感谢您提交的PR。 🙏
请再次查看您的PR内容,确认是否包含任何使用方式/API/配置参数的变更,如:新增API、新增配置参数、修改默认配置等操作。
如果是,请确保在提交之前,在仓库nacos-group/nacos-group.github.io中的docs/next/目录下添加或更新文档(markdown格式)。

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 92.85714% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...alibaba/nacos/common/json/JsonAdapterLogUtils.java 90.90% 0 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

@KomachiSion
KomachiSion merged commit 5f56cbb into alibaba:develop Jun 26, 2026
7 checks passed
@KomachiSion KomachiSion added this to the 3.3.0 milestone Jun 26, 2026
@KomachiSion
KomachiSion deleted the codex/jackson-adapter-final-cleanup branch June 26, 2026 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants