Repository navigation
[Security] Harden distributed database query result resolution - #15661
Merged
KomachiSion merged 1 commit intoAug 6, 2026
Merged
KomachiSion merged 1 commit into
KomachiSion merged 1 commit into
Conversation
Validate SelectRequest result targets and eagerly register distributed row mappers. Assisted-by: Claude Code
|
Thanks for your this PR. 🙏 感谢您提交的PR。 🙏 |
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
KomachiSion
added a commit
that referenced
this pull request
Aug 10, 2026
5 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Distributed embedded database read requests carry a result
className. The receiver previously resolved scalar result classes from the request through dynamic class loading and did not reject unknown row mapper names before JDBC execution.This change constrains result resolution to known targets and makes every distributed row mapper available on receiving nodes before requests are served.
No public GitHub issue is linked because this is a security-hardening change, and the Nacos contribution guidance directs security reports away from public issues.
Brief changelog
Integer,Long, andString.RowMapperManager.Verifying this change
mvn -B -pl core,ai,plugin-default-impl/nacos-default-auth-plugin clean compile apache-rat:check checkstyle:check spotbugs:check spotless:check -e -Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warnmvn -pl core -Dtest=DistributedDatabaseOperateImplTest test(30 tests)mvn -pl ai -Dtest=AiResourceRowMappersTest,EmbeddedAiResourcePersistServiceImplTest,EmbeddedAiResourceVersionPersistServiceImplTest test(15 tests)mvn -pl plugin-default-impl/nacos-default-auth-plugin -Dtest=AuthRowMapperManagerTest,NacosAuthPluginPersistenceConfigTest test(7 tests)Follow this checklist to help us incorporate your contribution quickly and easily: