Repository navigation
[Plugin] Decouple visibility plugin from server modules - #15678
Merged
KomachiSion merged 1 commit intoAug 10, 2026
Merged
KomachiSion merged 1 commit into
KomachiSion merged 1 commit into
Conversation
Assisted-by: Codex
|
Thanks for your this PR. 🙏 感谢您提交的PR。 🙏 |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
The independently published
nacos-visibility-pluginartifact should expose only the contracts required by external plugin implementations. Its server-side runtime currently depends onnacos-sys, which couples plugin developers to Nacos server internals.Brief changelog
VisibilityPluginManager,VisibilityPluginProvider, andVisibilityPluginTypePolicyintonacos-corenacos-visibility-pluginto a provided dependency onnacos-apiVisibilityService#init(Properties)compatibility path for existing implementationsVerifying this change
mvn -B -pl plugin/visibility,core,ai -am spotless:apply spotless:check clean test -Dtest=VisibilityPluginManagerTest,VisibilityPluginProviderTest,VisibilityPluginTypePolicyTest,VisibilityHelperTest,PromptOperationServiceImplTest,SkillListFilterTest,SkillOperationServiceImplTest,AiResourceManagerTest,AgentSpecListFilterTest,AgentSpecOperationServiceImplTest,ValidationResultTest -Dsurefire.failIfNoSpecifiedTests=false -DtrimStackTrace=falsemvn -B -pl plugin/visibility,core,ai -am compile apache-rat:check checkstyle:check spotbugs:check spotless:check -DskipTestsnacos-visibility-plugincompile dependency tree contains onlynacos-apiand no server moduleChecklist