Repository navigation
Fix active health check target address validation - #15712
Merged
KomachiSion merged 1 commit intoAug 14, 2026
Merged
KomachiSion merged 1 commit into
KomachiSion merged 1 commit into
Conversation
Validate active health check hosts before processor dispatch and isolate MySQL JDBC properties from target construction. Assisted-by: OpenAI Codex
|
Thanks for your this PR. 🙏 感谢您提交的PR。 🙏 |
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Active health check processors construct network targets from the registered instance address. The address should remain a plain host and must not introduce additional URL components into processor-specific connection strings.
This change validates active health check targets before processor dispatch. Invalid targets are treated as failed checks without invoking the concrete processor. It also separates the MySQL JDBC URL from connection properties and explicitly disables local-file and multi-query capabilities.
Brief changelog
Propertieswhile keeping the JDBC URL limited to host and port.Verifying this change
mvn -B clean compile apache-rat:check checkstyle:check spotbugs:check spotless:check -e -Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warnmvn -pl naming -Dtest=HealthCheckAddressValidatorTest,HealthCheckProcessorV2DelegateTest,MysqlHealthCheckProcessorTest testFollow this checklist to help us incorporate your contribution quickly and easily:
[ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body. This PR has no public issue number.mvn -B clean package apache-rat:check spotbugs:check -DskipTeststo make sure basic checks pass. Runmvn clean installto make sure unit-test pass. Runmvn clean test-compile failsafe:integration-testto make sure integration-test pass. The current GitHub CI equivalent check and affected unit tests passed as listed above.