Skip to content

Roll up legacy and next UI security dependency fixes - #15944

Merged
KomachiSion merged 2 commits into
alibaba:developfrom
KomachiSion:codex/ui-security-rollup-20261026
Oct 26, 2026
Merged

KomachiSion merged 2 commits into
alibaba:developfrom
KomachiSion:codex/ui-security-rollup-20261026

Conversation

@KomachiSion

Copy link
Copy Markdown
Collaborator

What is the purpose of the change

Consolidate the current legacy and next console UI security dependency PRs against develop, and ship rebuilt static assets for both UIs. This resolves 11 of the 12 open UI dependency PRs; the legacy webpack-dev-server migration remains outside this rollup.

Brief changelog

console-ui-next

  • Retain compatible npm audit fix --registry=https://registry.npmjs.org/ updates, including Vite 8.3.5, axios 1.20.0, follow-redirects 1.16.1, source-map-js 1.2.2, brace-expansion and Zod 4.6.7.
  • Update the pinned DOMPurify dependency from 3.4.13 to 3.4.17. The 3.4.16 version proposed in build(deps): bump dompurify from 3.4.13 to 3.4.16 in /console-ui-next #15888 still has reported vulnerabilities. Version 3.4.17 was published on 2026-10-12 and satisfies the configured 3-day min-release-age policy. Keep the existing Monaco sanitizer alias and override; the rebuilt runtime includes 3.4.17.
  • Preserve the worker fixture entry exports in the browser compatibility test. Vite now removes unused workers, so the fixture must retain its exported constructor to exercise the Chromium 90 polyfill. Production browser targets are unchanged.

Legacy console-ui

  • Retain automatic lockfile updates for body-parser 1.20.9, brace-expansion 1.1.21, compression 1.8.2, follow-redirects 1.16.2, moment 2.31.0, pbkdf2 3.1.7, postcss-selector-parser 6.1.5, proxy-addr 2.0.8, source-map-js 1.2.2 and to-buffer 1.2.2.
  • Revert the automatic Babel dependency group update after reproducing a build regression with a clean npm ci: changed parsing behavior in the old babel-eslint/eslint-loader toolchain exposes lint errors. The original dependency graph builds, and rebuilding with only that update group reverted passes. Retain all six unrelated dependency PR fixes.
  • Do not migrate webpack-dev-server from 3.x to 6.x: the current fix requires webpack ^5.101.0 and Node >=22.15.0, while the legacy project uses webpack 4. No forced upgrades or new overrides are used.

Related PRs

UI PR Dependency Result
Next #15932 vite Fixed at 8.3.5
Next #15924 follow-redirects Fixed at 1.16.1
Next #15910 source-map-js Fixed at 1.2.2
Next #15888 dompurify Fixed at 3.4.17, including advisories still affecting 3.4.16
Next #15887 axios Fixed at 1.20.0
Legacy #15925 follow-redirects Fixed at 1.16.2
Legacy #15894 proxy-addr Fixed at 2.0.8
Legacy #15892 brace-expansion Fixed at 1.1.21
Legacy #15891 source-map-js Fixed at 1.2.2
Legacy #15890 compression Fixed at 1.8.2
Legacy #15886 moment Fixed at 2.31.0
Legacy #15893 webpack-dev-middleware / webpack-dev-server Not resolved: requires the webpack 5 migration

Remaining audit findings

  • Next: 11 -> 4 reported vulnerable packages, all remaining findings moderate. They are @vitest/mocker/vitest and postcss-selector-parser/@tailwindcss/typography. Two bounded automatic passes made no further progress; neither chain has an open UI dependency PR in this inventory, so manual changes are outside this rollup. npm suggests a breaking downgrade of typography to 0.5.4 for the latter chain.
  • Legacy: 103 -> 95 reported vulnerable packages (8 low, 52 moderate, 30 high, 5 critical). All six resolved PR package entries are absent from the final audit. Remaining paths include webpack/dev-server, axios 0.x, Babel/babel-preset-react-app, PostCSS/cssnano, swiper, serialize-javascript/copy-webpack-plugin, old ESLint/tmp and uuid. Some require breaking toolchain upgrades; others remain after the bounded automatic retry. These are not claimed fixed.
  • The legacy follow-redirects version differs from the next UI because only the next project configures the 3-day release-age policy.

Verifying this change

Local runtime: Node 24.15.0 / npm 11.12.1, using the existing local NVM installation.

  • Legacy: clean npm ci --registry=https://registry.npmjs.org/ && npm run build passes with the retained updates; the existing parser/deprecation warnings remain.
  • Next: npm run build passes and static assets are regenerated.
  • Next: the CI-equivalent npm run min-release-age passes in an isolated checkout.
  • Next: npm test reports 457 passed / 10 failed, plus 2 test files that fail to load. The failing test and load-failure sets are identical to a clean upstream/develop baseline with its original lockfile. All five build/__tests__/browser-target.test.ts checks pass after the fixture adjustment. Unrelated baseline test failures were not changed.
  • Headless Chrome smoke checks pass for both packaged login pages with mocked backend responses: password fields work, and no page errors occur. Browser DOMPurify 3.4.17 sanitization and packaged sanitizer version were checked; generated relative JS imports resolve. This is not a backend integration test.
  • Final npm audit --registry=https://registry.npmjs.org/ results are recorded above; both commands exit nonzero because findings remain.
  • Full CI-equivalent Maven check passes in a clean source checkout (all reactor modules, 14m17s): mvn -B clean compile apache-rat:check checkstyle:check spotbugs:check spotless:check -e -Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn. Existing ignored investigation logs in the original workspace triggered RAT, so validation was repeated without those local logs. Final packaged assets were copied into the clean checkout before the console module check.

No HTTP API, Java SDK contract, or product behavior changes are intended; no API/SDK IT matrix changes are needed.

Retain validated automatic security upgrades and rebuild the legacy UI. Keep incompatible Babel and webpack toolchain migrations out of this rollup.

Assisted-by: Codex
Upgrade DOMPurify to 3.4.17, retain automatic audit fixes and preserve the worker test entry when Vite prunes unused workers.

Assisted-by: Codex
@github-actions

Copy link
Copy Markdown

Thanks for your this PR. 🙏
Please check again for your PR changes whether contains any usage/api/configuration change such as Add new API , Add new configuration, Change default value of configuration.
If so, please add or update documents(markdown type) in docs/next/ for repository nacos-group/nacos-group.github.io


感谢您提交的PR。 🙏
请再次查看您的PR内容,确认是否包含任何使用方式/API/配置参数的变更,如:新增API、新增配置参数、修改默认配置等操作。
如果是,请确保在提交之前,在仓库nacos-group/nacos-group.github.io中的docs/next/目录下添加或更新文档(markdown格式)。

@KomachiSion KomachiSion added dependencies Pull requests that update a dependency file area/Nacos console Related to Nacos consle labels Oct 26, 2026
@KomachiSion KomachiSion added this to the 3.3.0 milestone Oct 26, 2026
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@KomachiSion
KomachiSion merged commit 7ff2bd7 into alibaba:develop Oct 26, 2026
9 checks passed
@KomachiSion
KomachiSion deleted the codex/ui-security-rollup-20261026 branch October 26, 2026 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/Nacos console Related to Nacos consle dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants