Repository navigation
[ISSUE #15946] Preserve empty Skill resources and multiline descriptions - #15948
Merged
KomachiSion merged 1 commit intoOct 27, 2026
Merged
Conversation
…scriptions Treat only null formal configuration content as missing so empty Skill resource files remain readable. Parse YAML block scalars with SnakeYAML and reuse the result during Skill frontmatter normalization. Add regression and HTTP integration coverage and clarify the corresponding Skill and configuration query contracts. Fixes alibaba#15946 Fixes alibaba#15947 Assisted-by: Codex
|
Thanks for your this PR. 🙏 感谢您提交的PR。 🙏 |
KomachiSion
approved these changes
Oct 27, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please do not create a Pull Request without creating an issue first.
Fixes #15946
Fixes #15947
Fixes #15945
What is the purpose of the change
Skill creation/upload accepts an empty resource file, but the Config read path treats its content as missing and breaks subsequent version reads or downloads. Multiline YAML descriptions are also normalized to
|and can generate spurious fields such asdescription.Triggers. Preserve empty resources and return the complete parsed description from Skill list/detail APIs.Existing incorrect description metadata is refreshed by a content update or re-upload; this change does not backfill historical metadata.
Brief changelog
nullformal configuration content as absent; preserve empty and whitespace-only content and response metadata.Verifying this change
mvn -pl config,ai -Dtest=FormalHandlerTest,SkillZipParserTest,SkillRequestUtilTest,SkillFrontMatterTest,NacosConfigAiResourceStorageTest -Dsurefire.failIfNoSpecifiedTests=false testconfigandai.mvn -pl test/openapi-test -Pintegration-test -DskipTests test-compilepasses. The new HTTP scenarios have not been executed against a running server.Follow this checklist to help us incorporate your contribution quickly and easily:
[ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.mvn spotless:applyto format your code. Runmvn -B clean compile apache-rat:check checkstyle:check spotbugs:check spotless:check -DskipTeststo make sure basic checks pass. Runmvn clean installto make sure unit-test pass. Runmvn clean test-compile failsafe:integration-testto make sure integration-test pass.