Skip to content

Fix member hashcode/equals with different fileds if ip/port are setted by third. - #15951

Merged
KomachiSion merged 1 commit into
alibaba:v2.x-developfrom
lpaz010:fix-member-hashcode-equals
Oct 27, 2026
Merged

KomachiSion merged 1 commit into
alibaba:v2.x-developfrom
lpaz010:fix-member-hashcode-equals

Conversation

@lpaz010

@lpaz010 lpaz010 commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

com.alibaba.nacos.core.cluster.Member类hashcode()中基于 Objects.hash(ip, port),但equals() 在双方 address 均非空时改为按 address 比较。这违反 equals/hashCode 契约。

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn spotless:apply to format your code. Run mvn -B clean compile apache-rat:check checkstyle:check spotbugs:check spotless:check -DskipTests to make sure basic checks pass. Run mvn clean install to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

@lpaz010 lpaz010 closed this Oct 27, 2026
@lpaz010 lpaz010 reopened this Oct 27, 2026
@lpaz010
lpaz010 changed the base branch from develop to v2.x-develop October 27, 2026 08:53
@github-actions

Copy link
Copy Markdown

Thanks for your this PR. 🙏
Please check again for your PR changes whether contains any usage/api/configuration change such as Add new API , Add new configuration, Change default value of configuration.
If so, please add or update documents(markdown type) in docs/next/ for repository nacos-group/nacos-group.github.io


感谢您提交的PR。 🙏
请再次查看您的PR内容,确认是否包含任何使用方式/API/配置参数的变更,如:新增API、新增配置参数、修改默认配置等操作。
如果是,请确保在提交之前,在仓库nacos-group/nacos-group.github.io中的docs/next/目录下添加或更新文档(markdown格式)。

@KomachiSion
KomachiSion merged commit 6bd3874 into alibaba:v2.x-develop Oct 27, 2026
4 checks passed
@KomachiSion KomachiSion added this to the 2.5.5 milestone Oct 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants