Skip to content

[ISSUE #9277] publisherIndexes clean the service key when no instance… - #9278

Merged
KomachiSion merged 1 commit into
alibaba:developfrom
pixystone:remove-empty-service-keys-for-client-indexs-map
Oct 10, 2022
Merged

KomachiSion merged 1 commit into
alibaba:developfrom
pixystone:remove-empty-service-keys-for-client-indexs-map

Conversation

@pixystone

Copy link
Copy Markdown
Contributor

…s anymore.

What is the purpose of the change

Fix #9277

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Merging #9278 (76ab185) into develop (5396858) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #9278      +/-   ##
=============================================
+ Coverage      44.08%   44.10%   +0.01%     
- Complexity      4858     4860       +2     
=============================================
  Files            913      913              
  Lines          33047    33047              
  Branches        3825     3826       +1     
=============================================
+ Hits           14569    14575       +6     
+ Misses         17059    17053       -6     
  Partials        1419     1419              
Impacted Files Coverage Δ
...ing/core/v2/index/ClientServiceIndexesManager.java 73.13% <100.00%> (+2.98%) ⬆️
...alibaba/nacos/core/remote/control/TpsRecorder.java 74.32% <0.00%> (-1.36%) ⬇️
...alibaba/nacos/client/config/impl/ClientWorker.java 55.16% <0.00%> (-0.20%) ⬇️
.../core/v2/event/publisher/NamingEventPublisher.java 76.25% <0.00%> (+1.25%) ⬆️
...m/alibaba/nacos/core/remote/ConnectionManager.java 44.37% <0.00%> (+1.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5396858...76ab185. Read the comment docs.

@KomachiSion KomachiSion added the kind/bug Category issues or prs related to bug. label Oct 10, 2022
@KomachiSion KomachiSion added this to the 2.1.2 milestone Oct 10, 2022
@KomachiSion
KomachiSion merged commit 9c771cf into alibaba:develop Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/bug Category issues or prs related to bug.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Service removal dose not clean the ClientServiceIndex

3 participants