Skip to content

Improve logging on map/generic votes - #1362

Merged
Headline merged 4 commits into
alliedmodders:masterfrom
PlayBoy31:Improve-logging-on-map/generic-votes
Mar 8, 2021
Merged

Headline merged 4 commits into
alliedmodders:masterfrom
PlayBoy31:Improve-logging-on-map/generic-votes

Conversation

@PlayBoy31

Copy link
Copy Markdown
Contributor

Logging action is useful for serversโ€™ owners with large number of admins. Actually, map votes and generic votes are not very verbose on what have been done. This request tries to improve the logging of those votes by adding maps names and question with answers in the log.

Logging action is useful for serversโ€™ owners with large number of admins. Actually, map votes and generic votes are not very verbose on what have been done. This request tries to improve the logging of those votes by adding maps names and question with answers in the log.
Logging action is useful for serversโ€™ owners with large number of admins. Actually, map votes and generic votes are not very verbose on what have been done. This request tries to improve the logging of those votes by adding maps names and question with answers in the log.
@KyleSanderson

Copy link
Copy Markdown
Member

Thank you for the PR!

I've had donation for admin for well over a decade, however logging results from votes from clients hasn't been on the list. I'm really conflicted on this one, but I won't close this one out for a month+ until my peers have had a chance to review it as well. I simply can't see a case where I'd care what little Jimmy voted about what big Playboy31 started the vote about. I'd perhaps care about about what privileged commands Playboy31 is running (readas: the vote, and others), but then I'd add a CommandListener and see it all as part of the standard API.

If visibility is what you're after I can try to help you, but for now I don't see this helping core SM.

@peace-maker peace-maker left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't add logging for every single client's answer on a vote, but enhances the log to include the actual topic of the vote. So instead of only logging "PlayBoy31 initiated a generic vote." it logs the question and the pool of answers to choose from as well like "PlayBoy31 initiated a generic vote (question: XXX, answers: YY ZZ)".

Thank you, looks good. One thing inline.

Comment thread plugins/basevotes.sp Resolved
@Headline
Headline merged commit 52c4d08 into alliedmodders:master Mar 8, 2021
@PlayBoy31
PlayBoy31 deleted the Improve-logging-on-map/generic-votes branch March 8, 2021 17:28
@KyleSanderson

Copy link
Copy Markdown
Member

Ah! My bad, thanks for that. Not sure what I was thinking

@PlayBoy31

Copy link
Copy Markdown
Contributor Author

Thanks for the review all and for the approval

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants