Skip to content

Fix translation buffers not terminating at last cell - #1640

Merged
asherkin merged 1 commit into
alliedmodders:masterfrom
Adrianilloo:1.10-dev
Nov 16, 2021
Merged

asherkin merged 1 commit into
alliedmodders:masterfrom
Adrianilloo:1.10-dev

Conversation

@Adrianilloo

@Adrianilloo Adrianilloo commented Nov 15, 2021 •

Copy link
Copy Markdown
Contributor

Fixes #1594 per @dvander instructions and self tests

@asherkin

Copy link
Copy Markdown
Member

Please could you rebase and retarget this PR against the master branch.

@Adrianilloo
Adrianilloo changed the base branch from 1.10-dev to master November 15, 2021 22:44
@Adrianilloo
Adrianilloo deleted the 1.10-dev branch November 15, 2021 22:50
@Adrianilloo
Adrianilloo restored the 1.10-dev branch November 15, 2021 22:51
@Adrianilloo Adrianilloo reopened this Nov 15, 2021
@Adrianilloo

Adrianilloo commented Nov 15, 2021 •

Copy link
Copy Markdown
Contributor Author

Ok, followed your steps now. Failed at trying to switch the source branch as well, but that isn't possible.

@asherkin asherkin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - LGTM

@asherkin
asherkin merged commit 18f9d65 into alliedmodders:master Nov 16, 2021
@Adrianilloo

Adrianilloo commented Nov 16, 2021 •

Copy link
Copy Markdown
Contributor Author

Thanks! Will this be made into 1.10 as well?

@asherkin

Copy link
Copy Markdown
Member

Will this be made into 1.10 as well?

We're not currently backporting non-critical things to 1.10 as we're in the final push for 1.11 - please do upgrade to 1.11 and test it out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Translated buffers are early null terminated

2 participants