Skip to content

Add Shield and Bumpmine to cstrike.inc - #991

Merged
Headline merged 2 commits into
alliedmodders:masterfrom
Bara:patch-6
May 24, 2019
Merged

Headline merged 2 commits into
alliedmodders:masterfrom
Bara:patch-6

Conversation

@Bara

@Bara Bara commented May 1, 2019

Copy link
Copy Markdown
Contributor

@psychonic
psychonic requested a review from Drifter321 May 14, 2019 23:16
@qubka

qubka commented May 24, 2019

Copy link
Copy Markdown

May be better to do smth like that ? f5ad5af

@Drifter321 Drifter321 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bumpmine is fine. Shield should not be added to the enum as it would break id's below it. The extension function GetWeaponIdFromDefIdx should be updated to have the respective SMCSWeapon_NONE be SMCSWeapon_SHIELD

Remove CSWeapon_SHIELD from CSWeaponID
@Bara

Bara commented May 24, 2019

Copy link
Copy Markdown
Contributor Author

πŸ‘ŒπŸ»

@Headline
Headline merged commit 9c55eed into alliedmodders:master May 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants