[BUG] If there are spaces in ANDROID_SDK_ROOT, ndk-build will not work. #1400

Activity

1. vvb2060

   added

   bug

   on Dec 14, 2020
2. DanAlbert commented on Dec 14, 2020

   

   DanAlbert

   on Dec 14, 2020

   Contributor

   More actions

   I doubt this is something that will ever work reliably, FYI. This is extremely difficult to do correctly in a make based system, especially one like ours which makes heavy use of eval (you need to escape variables differently depending on how deep it will be used in a callstack).

   We should probably emit a warning if the NDK is installed to such a path. We already do that when the source is in a path that contains spaces, but we don't check the NDK itself I guess.

   We should also squash this particular case, but I suspect we'll regress.

   👍React with 👍1Reacted by Alex Cohn
3. DanAlbert

   added this to NDK r26on Jun 27, 2022
4. DanAlbert

   moved this to Triaged in NDK r26on Jun 27, 2022
5. DanAlbert commented on Apr 20, 2023

   

   DanAlbert

   on Apr 20, 2023

   Contributor

   More actions

   Apparently this is already forbidden: https://android.googlesource.com/platform/ndk/+/refs/heads/master/build/ndk-build#53 and https://android.googlesource.com/platform/ndk/+/refs/heads/master/build/core/build-local.mk#43. The former of course isn't used on Windows, but the latter doesn't appear to work there either. Your GHA log has unfortunately been culled, so I have no idea what the original report was, but this does seem quite broken on Windows.
6. vvb2060 commented on Apr 20, 2023

   

   vvb2060

   on Apr 20, 2023

   Author

   More actions

   actions/runner-images#1122 (comment)
7. DanAlbert commented on Apr 20, 2023

   

   DanAlbert

   on Apr 20, 2023

   Contributor

   More actions

   Adding this seems to be the way to catch the problem (will upload a patch in a moment):

   for /f "tokens=2" %%a in ("%~dp0") do (
       echo ERROR: NDK path cannot contain spaces
       exit /b 1
   )
8. DanAlbert commented on Apr 20, 2023

   

   DanAlbert

   on Apr 20, 2023

   Contributor

   More actions

   actions/runner-images#1122 (comment)

   Thanks! I tried the same thing you did (quote the thing in ndk-build.cmd) and ran into the same problem (that's insufficient). The fix you ended up merging makes sense to me.

   Apparently this is already forbidden: https://android.googlesource.com/platform/ndk/+/refs/heads/master/build/ndk-build#53 and https://android.googlesource.com/platform/ndk/+/refs/heads/master/build/core/build-local.mk#43

   make can't catch the second case on windows. $(lastword $(MAKEFILE_LIST)) when the NDK's install directory is android-ndk-r25c with spaces is spaces\build\..\build\core\build-local.mk. ndk-build.cmd already passes a quoted path to make, so that really is just make being different on Windows (a bug, but not one I care to chase).
9. DanAlbert commented on Apr 20, 2023

   

   DanAlbert

   on Apr 20, 2023

   Contributor

   More actions

   https://android-review.googlesource.com/c/platform/ndk/+/2552855 and https://android-review.googlesource.com/c/platform/ndk/+/2552856
10. DanAlbert commented on Apr 20, 2023

    

    DanAlbert

    on Apr 20, 2023

    Contributor

    More actions

    make can't catch the second case on windows.

    This, in case it wasn't clear, is a pretty big blocker for us ever doing better at this. Still probably less problematic than eval, but it's an early enough blocker that I don't think it's even worth trying.
11. DanAlbert

    closed this as completedon May 1, 2023
12. github-project-automation

    moved this from Triaged to Merged in NDK r26on May 1, 2023
13. foxsen

    added a commit that references this issue on Oct 10, 2024

    Check for paths with spaces in ndk-build.cmd.

    ...

    a133957