Skip to content

Merging Notetypes on Import - #2612

Merged
dae merged 48 commits into
ankitects:mainfrom
RumovZ:notetype-import
Sep 8, 2023
Merged

dae merged 48 commits into
ankitects:mainfrom
RumovZ:notetype-import

Conversation

@RumovZ

@RumovZ RumovZ commented Aug 19, 2023

Copy link
Copy Markdown
Collaborator

Fixes #2482.

As you can see, the problem is with the help modal (and also the revert arrow, but I haven't spend much time looking into that). Would appreciate your help.

grafik

@RumovZ RumovZ changed the title Notetype import Merging Notetypes on Import Aug 19, 2023
@dae

dae commented Aug 20, 2023

Copy link
Copy Markdown
Member

Modal issue turned out to be fairly simple thankfully - while one would logically expect HelpModal to be self-contained, it relies on global bootstrap styles.

@RumovZ

RumovZ commented Aug 20, 2023

Copy link
Copy Markdown
Collaborator Author

Thanks! I'm lost regarding those dependencies in the web layer. 🙂
Maybe it would make sense to add an OptionsPage.svelte component which would be an abstraction of DeckOptionsPage.svelte. Presumably, the number of options dialogs in the web layer will only grow.

Comment thread rslib/src/notetype/fields.rs Resolved
@RumovZ

RumovZ commented Aug 20, 2023

Copy link
Copy Markdown
Collaborator Author

There's also a more general issue I could use help with: If a job fails, I don't get any helpful error message. E.g. I'm currently struggling to add a field to a proto message, but the only output I get is this:

C:\code\anki [notetype-import ↑3 +1 ~5 -0 !]> ./run
    Finished release [optimized] target(s) in 0.27s
failed: pylib:rsbridge

Build failed.

It's the same for other jobs and whether I use ninja check, ninja check:eslint:import-anki-package or whatever. Is it the same for you?

@abdnh

abdnh commented Aug 21, 2023

Copy link
Copy Markdown
Member

If a job fails, I don't get any helpful error message.

@RumovZ I struggled with this while working on my last PR but forgot to report it. Very frustrating.

dae added a commit to RumovZ/anki that referenced this pull request Aug 21, 2023
@dae

dae commented Aug 21, 2023

Copy link
Copy Markdown
Member

This was a Windows-specific issue - please try updating n2 using the link above.

@dae dae closed this in bc295b4 Aug 21, 2023
@dae dae reopened this Aug 21, 2023
@dae

dae commented Aug 21, 2023

Copy link
Copy Markdown
Member

Sorry, pushing that fix to the main branch caused GitHub to think it "fixed" this PR, not the linked comment.

@RumovZ