Repository navigation
Tooltips for CSV import and import page refactoring - #2655
Merged
Merged
Conversation
dae
reviewed
Sep 13, 2023
dae
left a comment
dae
left a comment
Member
There was a problem hiding this comment.
Will try to review this properly tomorrow, but one issue I noticed so far: when importing an .apkg file, progress is no longer shown correctly.
Co-authored-by: Damien Elmes <dae@users.noreply.github.com>
Collaborator
Author
|
Thanks. Should've tested with larger imports. |
e.g. 500: Failed to read '/home/dae/foo2.csv':<br>stream did not contain valid UTF-8
I thought about using {@html ...} here, but that's a potential security issue,
as the filename is not something we control.
dae
reviewed
Sep 13, 2023
| export let value = 0; | ||
| type T = $$Generic; | ||
|
|
||
| export let value: T; |
| <Row><FileOptions {state} /></Row> | ||
| <Row><ImportOptions {state} /></Row> | ||
| <Row><FieldMapper {state} /></Row> | ||
| </ImportPage> |
| notetypeColumn: tryGetNotetypeColumn(metadata), | ||
| deckId: tryGetDeckId(metadata), | ||
| deckColumn: tryGetDeckColumn(metadata), | ||
| state: new ImportCsvState(path, notetypes, decks, metadata), |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As always, please go ahead if you see any room for improvement, especially with the fluent strings or the styling, which I'm not super confident with.
@abdnh, your input is welcome as well, of course!