Skip to content

Add auto-advance options to deck preset - #2765

Merged
dae merged 16 commits into
ankitects:mainfrom
abdnh:auto-advance
Nov 13, 2023
Merged

Add auto-advance options to deck preset#2765
dae merged 16 commits into
ankitects:mainfrom
abdnh:auto-advance

Conversation

@abdnh

@abdnh abdnh commented Oct 22, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

Closes #2645

@abdnh
abdnh marked this pull request as draft October 22, 2023 10:08
@abdnh
abdnh marked this pull request as ready for review October 24, 2023 17:42
dae
dae reviewed Oct 24, 2023
View reviewed changes

@dae dae left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Sorry, I forgot to mention one thing about how this should work: there should be a menu action that toggles auto-advance, so it doesn't happen until the user explicitly starts it. Its value shouldn't be saved, so it should always start off. The primary reason for this is that the congratulations page will switch back to review when the day rolls over, and users won't want to wake up to find all their cards have already been answered. :-)

Comment thread qt/aqt/reviewer.py Outdated
timer = None

if conf["secondsToShowAnswer"]:
timer = self._show_answer_timer = self.mw.progress.timer(

@dae dae Oct 24, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any particular reason you didn't use single_shot() here?

@abdnh abdnh Oct 25, 2023

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is to compare the timers so that we make sure a previous card's timer doesn't get to execute on the next card.

@abdnh

abdnh commented Oct 25, 2023

Copy link
Copy Markdown
Member Author

users won't want to wake up to find all their cards have already been answered. :-)

That's a feature I'd love to use 😂

abdnh
abdnh commented Oct 25, 2023
View reviewed changes
Comment thread qt/aqt/reviewer.py Resolved
@dae

dae commented Oct 26, 2023

Copy link
Copy Markdown
Member

Couple of remaining issues:

  • toggling auto-advance to on doesn't start it until you manually show answer
  • it remains on when you go back to the overview and then back into review
  • it might be nice if we automatically stop it when the user opens add/edit/browse

@dae

dae commented Oct 28, 2023

Copy link
Copy Markdown
Member

(in case it wasn't clear, I'm planning to skip over this for the 23.10 release, so there's no time pressure on this)

@dae

dae commented Nov 2, 2023

Copy link
Copy Markdown
Member

Thanks Abdo. I might need to hold off on this for a week or two, so we can get a hotfix update out first.

@dae
dae merged commit ae7b14b into ankitects:main Nov 13, 2023
@abdnh
abdnh deleted the auto-advance branch November 13, 2023 04:26
@abdnh abdnh mentioned this pull request