Skip to content

Return current weights if fsrs items is zero & handle error in evaluation and optimal retention - #3141

Merged
dae merged 6 commits into
ankitects:mainfrom
L-M-Sherlock:return-current-weights-if-fsrs_items-is-zero-&-handle-error-in-evaluation
Apr 17, 2024
Merged

dae merged 6 commits into
ankitects:mainfrom
L-M-Sherlock:return-current-weights-if-fsrs_items-is-zero-&-handle-error-in-evaluation

Conversation

@L-M-Sherlock

Copy link
Copy Markdown
Contributor

Related discussion: https://forums.ankiweb.net/t/anki-24-04-2-beta/43562/8?u=l.m.sherlock

I don't know why the error isn't handled like Anki 24.04.1:

image

So I handle it in the .svelte file. I'm not sure it is a right way to handle it. Please feel free to modify it.

@dae

dae commented Apr 17, 2024

Copy link
Copy Markdown
Member

Thanks Jarrett. I've pushed a more general fix for the unreported errors.

@dae
dae merged commit d1b2ab5 into ankitects:main Apr 17, 2024
@L-M-Sherlock
L-M-Sherlock deleted the return-current-weights-if-fsrs_items-is-zero-&-handle-error-in-evaluation branch April 17, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants