Skip to content

feat: add jovay icon - #1548

Merged
yutingzhao1991 merged 1 commit into
mainfrom
feat/jovay-icon
Nov 13, 2025
Merged

yutingzhao1991 merged 1 commit into
mainfrom
feat/jovay-icon

Conversation

@YeezoGao

@YeezoGao YeezoGao commented Nov 13, 2025 •

Copy link
Copy Markdown
Collaborator

[中文版模板 / Chinese template]

💡 Background and solution

添加了 jovay 的 icon

image

🔗 Related issue link

close #1547

Summary by CodeRabbit

发布说明

  • 新功能
    • 新增 Jovay Colorful 图标组件,支持在应用中使用该彩色图标。

@changeset-bot

changeset-bot Bot commented Nov 13, 2025

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: cd3d7bf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel

vercel Bot commented Nov 13, 2025 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
ant-design-web3 Ready Ready Preview Comment Nov 13, 2025 9:21am

@dosubot dosubot Bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Nov 13, 2025
@github-actions

github-actions Bot commented Nov 13, 2025 •

Copy link
Copy Markdown

Preview is ready

@coderabbitai

coderabbitai Bot commented Nov 13, 2025 •

Copy link
Copy Markdown
📝 Walkthrough

概览

向 packages/icons 包中添加新的 JovayColorful 图标组件。该组件基于 Ant Design 的 Icon 包装器实现,并通过主入口文件重新导出,完成功能实现。

变更

内聚组件 / 文件 变更摘要
新增 JovayColorful 图标组件
packages/icons/src/components/jovay-colorful.tsx
新增 React 函数式组件,使用 AntdIcon 封装 SVG,通过 ConfigProvider 获取前缀类名,支持 ref 转发和自定义 className 合并
更新包导出
packages/icons/src/index.ts
添加 export * from './components/jovay-colorful' 声明,将新图标组件公开暴露

代码审查工作量估计

🎯 1 (琐碎) | ⏱️ ~3 分钟

  • 新增文件采用标准图标组件模式,与现有组件结构一致
  • 导出语句为简单的模块重导出,无逻辑复杂性

诗

🐰✨ 一个新图标悄然而至,
Jovay 的色彩闪闪发光,
简单而优雅的组件设计,
让图标库更加丰富多彩,
兔兔为你庆祝这一刻!🎉

Pre-merge checks and finishing touches

✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed PR标题清晰准确地总结了主要变更——添加了Jovay图标组件,符合约定俗成的提交消息格式。
Linked Issues check ✅ Passed PR成功实现了#1547中的功能需求,通过添加新的JovayColorful图标组件并导出,完全满足需求。
Out of Scope Changes check ✅ Passed 所有代码变更均与添加Jovay图标的需求相关,包括新建组件文件和导出声明,不存在超出范围的更改。
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/jovay-icon

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0a24603 and cd3d7bf.

⛔ Files ignored due to path filters (3)
  • packages/icons/src/__tests__/__snapshots__/index.test.tsx.snap is excluded by !**/*.snap
  • packages/icons/src/svgs/jovay-colorful.svg is excluded by !**/*.svg
  • packages/web3/src/nft-image/__tests__/__snapshots__/index.test.tsx.snap is excluded by !**/*.snap
📒 Files selected for processing (2)
  • packages/icons/src/components/jovay-colorful.tsx (1 hunks)
  • packages/icons/src/index.ts (1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-08-13T08:59:54.489Z
Learnt from: CR
Repo: ant-design/ant-design-web3 PR: 0
File: .cursor/rules/basic.mdc:0-0
Timestamp: 2025-08-13T08:59:54.489Z
Learning: Applies to packages/web3/**/style/index.{ts,tsx} : Implement styles using ant-design/cssinjs and Ant Design Design Tokens

Applied to files:

  • packages/icons/src/index.ts
  • packages/icons/src/components/jovay-colorful.tsx
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: ci
  • GitHub Check: prepare preview
  • GitHub Check: ci
🔇 Additional comments (4)
packages/icons/src/components/jovay-colorful.tsx (3)

13-25: 组件实现正确!

组件实现遵循了项目中其他图标组件的标准模式:

  • 正确使用 forwardRef 进行 ref 转发
  • 通过 ConfigProvider 获取前缀类名以支持主题定制
  • 使用 classnames 合并类名
  • 应用 eraseDefaultProps 工具函数处理 SVG 组件

实现符合 Ant Design 和项目的最佳实践。


27-27: displayName 设置正确。

为组件设置 displayName 有助于在 React DevTools 中进行调试,命名与组件名称一致。


1-10: 导入规范符合要求。

所有导入依赖项(React、AntdIcon、ConfigProvider、classnames 等)与项目其他图标组件保持一致,遵循标准模式。SVG 源文件已确认存在于 packages/icons/src/svgs/jovay-colorful.svg,文件大小 1.9K,结构完整。该文件作为自动生成文件,其实现符合项目规范。

packages/icons/src/index.ts (1)

290-290: 确认生成脚本已正确执行,请勿手动编辑此文件。

导出位置字母顺序正确(iris-circle-colorful < jovay-colorful < jst-circle-colorful)。但请注意文件头部明确声明:"DO NOT EDIT IT MANUALLY",此文件由生成脚本自动维护。

请确认您已运行 npm run icons:generate 命令来生成此导出,而非手动添加。生成脚本位于 ./packages/icons/scripts/generate.ts。


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@gemini-code-assist

Copy link
Copy Markdown

Summary of Changes

Hello @LCJove, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new 'Jovay' colorful icon to the project's shared icon library. It includes the necessary SVG asset and a dedicated React component to render it, ensuring the icon is properly integrated and accessible for use across the application. This enhancement expands the visual assets available to developers.

Highlights

  • New Icon Component: A new React component named JovayColorful has been added, responsible for rendering the new Jovay icon.
  • SVG Asset Inclusion: The corresponding jovay-colorful.svg asset has been included in the svgs directory, providing the vector graphic for the icon.
  • Icon Export: The newly created JovayColorful component is now exported from the main index.ts file of the icons package, making it available for use throughout the project.
  • Test Snapshot Update: An outdated test snapshot in packages/web3/src/nft-image/__tests__/__snapshots__/index.test.tsx.snap was removed, likely as part of a cleanup or rebase.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@dosubot dosubot Bot added the feature Independent new features label Nov 13, 2025

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

这个 PR 添加了 jovay 图标,包括其 SVG 文件、React 组件以及在包中的导出。整体实现遵循了项目的现有模式,做得很好。

我主要有以下几点反馈:

  • 在 packages/icons/src/components/jovay-colorful.tsx 中,注释里有一个拼写错误 (DON NOT),建议在生成脚本中修复。
  • 新添加的 SVG 文件 packages/icons/src/svgs/jovay-colorful.svg 中包含中文的 id 和 data-name,建议修改为英文以提高代码的可维护性。
  • 一个位于 packages/web3 目录下的测试快照被移除了。这个改动和本次 PR 的主题似乎无关,并且移除测试快照可能隐藏潜在的回归问题,需要特别注意。

@codecov

codecov Bot commented Nov 13, 2025 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (0a24603) to head (cd3d7bf).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1548   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          875       876    +1     
  Lines        18856     18874   +18     
  Branches      1702      1703    +1     
=========================================
+ Hits         18856     18874   +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Nov 13, 2025
@yutingzhao1991
yutingzhao1991 merged commit 8fcfa48 into main Nov 13, 2025
2 checks passed
@yutingzhao1991
yutingzhao1991 deleted the feat/jovay-icon branch November 13, 2025 09:46

This branch was successfully deployed

1 active deployment
Preview — cd3d7bf8 Deployed Nov 13, 2025 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature Independent new features lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request] add jovay icon

3 participants