Skip to content

bugfix: metadata service support read dubbo:protocol - #10855

Merged
AlbumenJ merged 10 commits into
apache:3.1from
funky-eyes:read_dubbo_protocol
Nov 2, 2022
Merged

AlbumenJ merged 10 commits into
apache:3.1from
funky-eyes:read_dubbo_protocol

Conversation

@funky-eyes

Copy link
Copy Markdown
Contributor

What is the purpose of the change

fixes #10826

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@funky-eyes
funky-eyes requested a review from AlbumenJ November 1, 2022 07:16
Comment on lines +148 to +150

applicationModel.getApplicationConfigManager().getProtocol(specifiedProtocol)
.ifPresent(protocolConfig::mergeProtocol);

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this override port configuration?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this override port configuration?

No, it will only work on variables with null values

@funky-eyes
funky-eyes requested a review from AlbumenJ November 2, 2022 01:42
@codecov-commenter

codecov-commenter commented Nov 2, 2022 •

Copy link
Copy Markdown

Codecov Report

Merging #10855 (31aae5e) into 3.1 (a0367b7) will decrease coverage by 3.80%.
The diff coverage is 75.00%.

@@             Coverage Diff              @@
##                3.1   #10855      +/-   ##
============================================
- Coverage     68.39%   64.59%   -3.81%     
+ Complexity      534      469      -65     
============================================
  Files          1358     1336      -22     
  Lines         68917    56997   -11920     
  Branches      11945     8405    -3540     
============================================
- Hits          47135    36815   -10320     
+ Misses        17407    16223    -1184     
+ Partials       4375     3959     -416     
Impacted Files Coverage Δ
...n/java/org/apache/dubbo/config/ProtocolConfig.java 82.46% <64.70%> (-5.80%) ⬇️
...org/apache/dubbo/common/utils/CollectionUtils.java 80.98% <88.88%> (+0.46%) ⬆️
.../metadata/ConfigurableMetadataServiceExporter.java 78.78% <100.00%> (-3.38%) ⬇️
...luster/router/script/ScriptStateRouterFactory.java 0.00% <0.00%> (-100.00%) ⬇️
...zookeeper/curator/CuratorZookeeperTransporter.java 0.00% <0.00%> (-100.00%) ⬇️
...pc/cluster/router/file/FileStateRouterFactory.java 0.00% <0.00%> (-80.96%) ⬇️
...o/rpc/cluster/router/script/ScriptStateRouter.java 0.00% <0.00%> (-73.34%) ⬇️
...ting/zookeeper/curator/CuratorZookeeperClient.java 15.38% <0.00%> (-62.83%) ⬇️
...mmon/serialize/fastjson2/FastJson2ObjectInput.java 0.00% <0.00%> (-62.50%) ⬇️
...mon/serialize/fastjson2/FastJson2ObjectOutput.java 0.00% <0.00%> (-56.25%) ⬇️
... and 363 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@funky-eyes funky-eyes closed this Nov 2, 2022
@funky-eyes funky-eyes reopened this Nov 2, 2022

@AlbumenJ AlbumenJ left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlbumenJ
AlbumenJ merged commit 3e77b6b into apache:3.1 Nov 2, 2022
@funky-eyes funky-eyes changed the title bugfix: meatadata service support read dubbo:protocol bugfix: metadata service support read dubbo:protocol Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unable to change serialization type of MetadataService

3 participants