Repository navigation
bugfix: metadata service support read dubbo:protocol - #10855
Merged
Merged
Conversation
AlbumenJ
requested changes
Nov 1, 2022
AlbumenJ
requested changes
Nov 2, 2022
Comment on lines
+148
to
+150
|
|
||
| applicationModel.getApplicationConfigManager().getProtocol(specifiedProtocol) | ||
| .ifPresent(protocolConfig::mergeProtocol); |
Member
There was a problem hiding this comment.
Will this override port configuration?
Contributor
Author
There was a problem hiding this comment.
Will this override
portconfiguration?
No, it will only work on variables with null values
Codecov Report
@@ Coverage Diff @@
## 3.1 #10855 +/- ##
============================================
- Coverage 68.39% 64.59% -3.81%
+ Complexity 534 469 -65
============================================
Files 1358 1336 -22
Lines 68917 56997 -11920
Branches 11945 8405 -3540
============================================
- Hits 47135 36815 -10320
+ Misses 17407 16223 -1184
+ Partials 4375 3959 -416
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
fixes #10826
Brief changelog
Verifying this change
Checklist