Skip to content

bugfix: the issue of possible infinite loop when cleaning up expired metadata info - #15086

Merged
chickenlj merged 8 commits into
apache:3.3from
funky-eyes:0122
Feb 5, 2025
Merged

chickenlj merged 8 commits into
apache:3.3from
funky-eyes:0122

Conversation

@funky-eyes

@funky-eyes funky-eyes commented Jan 22, 2025 •

Copy link
Copy Markdown
Contributor

What is the purpose of the change?

fix #15087

Checklist

  • Make sure there is a GitHub_issue field for the change.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Make sure gitHub actions can pass. Why the workflow is failing and how to fix it?

@codecov-commenter

codecov-commenter commented Jan 22, 2025 •

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 94.44444% with 1 line in your changes missing coverage. Please review.

Project coverage is 60.75%. Comparing base (bda147a) to head (fc5a58b).
Report is 138 commits behind head on 3.3.

Files with missing lines Patch % Lines
...ubbo/registry/client/AbstractServiceDiscovery.java 94.44% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                3.3   #15086      +/-   ##
============================================
+ Coverage     60.73%   60.75%   +0.01%     
- Complexity    10864    10872       +8     
============================================
  Files          1882     1882              
  Lines         86009    86009              
  Branches      12886    12887       +1     
============================================
+ Hits          52239    52254      +15     
+ Misses        28322    28311      -11     
+ Partials       5448     5444       -4     
Flag Coverage Δ
integration-tests 33.06% <16.66%> (+0.03%) ⬆️
samples-tests 29.23% <16.66%> (+0.01%) ⬆️
unit-tests 58.88% <94.44%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@finefuture finefuture left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@chickenlj chickenlj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@chickenlj
chickenlj merged commit 49ede4f into apache:3.3 Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] The service enters an infinite loop of metadata cache cleanup under frequent registration.

4 participants