Skip to content

remove dubbo plugin useless dependency - #15236

Merged
CrazyHZM merged 1 commit into
apache:3.3from
RainYuY:remove-test-for-plugin
Apr 12, 2025
Merged

CrazyHZM merged 1 commit into
apache:3.3from
RainYuY:remove-test-for-plugin

Conversation

@RainYuY

@RainYuY RainYuY commented Mar 13, 2025

Copy link
Copy Markdown
Member

What is the purpose of the change?

Remove dubbo-test in dubbo-plugin

Checklist

  • Make sure there is a GitHub_issue field for the change.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Make sure gitHub actions can pass. Why the workflow is failing and how to fix it?

@codecov-commenter

codecov-commenter commented Mar 13, 2025 •

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.78%. Comparing base (d3b1e1f) to head (630f284).
Report is 143 commits behind head on 3.3.

Additional details and impacted files
@@             Coverage Diff              @@
##                3.3   #15236      +/-   ##
============================================
- Coverage     60.79%   60.78%   -0.01%     
+ Complexity    10892    10886       -6     
============================================
  Files          1885     1885              
  Lines         86082    86082              
  Branches      12895    12895              
============================================
- Hits          52331    52328       -3     
- Misses        28303    28309       +6     
+ Partials       5448     5445       -3     
Flag Coverage Δ
integration-tests 33.13% <ø> (-0.02%) ⬇️
samples-tests 29.19% <ø> (-0.01%) ⬇️
unit-tests 58.93% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@oxsean

oxsean commented Mar 14, 2025

Copy link
Copy Markdown
Contributor

Why remove it? is the SPI file shade check provider by this? If so, I don't think it can be removed

@RainYuY

RainYuY commented Mar 14, 2025

Copy link
Copy Markdown
Member Author

Why remove it? is the SPI file shade check provider by this? If so, I don't think it can be removed

No, I just removed dubbo-test-check. It's for integration testing. This is part of the removal of the dubbo-test module.

@RainYuY

RainYuY commented Apr 7, 2025

Copy link
Copy Markdown
Member Author

link #15301

@CrazyHZM
CrazyHZM merged commit 93cfa82 into apache:3.3 Apr 12, 2025
RainYuY added a commit to RainYuY/dubbo that referenced this pull request Apr 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants