Repository navigation
Fix: Stabilize ExporterSideConfigUrlTest by disabling metrics initialization during URL export - #15778
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 3.3 #15778 +/- ##
============================================
- Coverage 60.77% 58.84% -1.94%
+ Complexity 11706 15 -11691
============================================
Files 1938 1938
Lines 88646 88646
Branches 13379 13380 +1
============================================
- Hits 53875 52160 -1715
- Misses 29249 30832 +1583
- Partials 5522 5654 +132
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This was referenced Nov 22, 2025
4 tasks done
This was referenced Dec 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change?
This PR stabilizes the following three tests in
ExporterSideConfigUrlTest:exporterMethodConfigUrlTestexporterServiceConfigUrlTestexporterProviderConfigUrlTestThese tests were intermittently failing under randomized execution orders due to nondeterministic behavior in Micrometer’s composite meter registry, which was being initialized during Dubbo’s metrics setup, even though these URL-related tests do not depend on metrics.
Root Cause
When
servConf.export()is invoked insideverifyExporterUrlGeneration, Dubbo triggersDefaultApplicationDeployer.initialize(), which initializes metrics reporters (Prometheus by default).During this initialization, Micrometer’s
CompositeMeterRegistryiterates through an internalIdentityHashMapwhose iteration order is not deterministic under randomized JVM execution orders.Under certain NonDex seeds, this produces:
This exception happens before the test even begins validating URL parameters, making the failure unrelated to URL behavior.
The test suite never intended to validate metrics behavior here, so metrics initialization adds unnecessary non-determinism.
Changes Made
SysProps.clear()in both@BeforeEachand@AfterEachto preserve isolation.Verification
You can try running the following snippet of code from the dubbo repo root, on both pre-fix and post-fix code
The tests should fail intermittently on the pre-fix version, but pass consistently across all seeds on the post-fix version.
NonDex run logs will be available under the
dubbo-config/dubbo-config-api/.nondexdirectory.Checklist