Repository navigation
Fix: the interface-level timeout and retry configurations become invalid after the caller application is restarted - #15784
Merged
Conversation
…lid after the caller application is restarted Details: By moving the subscription logic after initializing referenceConfigurationListener in the dynamic configuration Addresses: apache#15783
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 3.3 #15784 +/- ##
============================================
- Coverage 60.77% 60.75% -0.02%
+ Complexity 11706 11689 -17
============================================
Files 1938 1938
Lines 88646 88646
Branches 13379 13379
============================================
- Hits 53875 53861 -14
- Misses 29249 29258 +9
- Partials 5522 5527 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zrlw
self-requested a review
November 20, 2025 07:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details: By moving the subscription logic after initializing referenceConfigurationListener in the dynamic configuration
Addresses: #15783
What is the purpose of the change?
What's the problem
In Dubbo 3.2.11 and all latest Dubbo 3 versions, the interface-level timeout and retry configurations become invalid after the caller application is restarted
Root cause
The investigation into why the referenceConfigurationListener was null points to a potential timing issue in the RegistryDirectory class's subscribe method: providers are being subscribed to before the referenceConfigurationListener is initialized.
How to fix
I solve this problem by placing the referenceConfigurationListener initialization logic before the call to super.subscribe(url).
Checklist