Skip to content

Set CONVERT_NO_LOWER_HEADER to true to keep it consistent with its initial value and avoid misunderstandings. - #15831

Merged
EarthChen merged 3 commits into
apache:3.3from
RainYuY:3.3
Dec 12, 2025
Merged

EarthChen merged 3 commits into
apache:3.3from
RainYuY:3.3

Conversation

@RainYuY

@RainYuY RainYuY commented Dec 10, 2025

Copy link
Copy Markdown
Member

What is the purpose of the change?

Set CONVERT_NO_LOWER_HEADER to true to keep it consistent with its initial value and avoid misunderstandings.

Checklist

  • Make sure there is a GitHub_issue field for the change.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Make sure gitHub actions can pass. Why the workflow is failing and how to fix it?

@codecov-commenter

codecov-commenter commented Dec 10, 2025 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.75%. Comparing base (13c021d) to head (ae2e8cc).
⚠️ Report is 15 commits behind head on 3.3.

Additional details and impacted files
@@             Coverage Diff              @@
##                3.3   #15831      +/-   ##
============================================
- Coverage     60.77%   60.75%   -0.02%     
+ Complexity    11706    11701       -5     
============================================
  Files          1938     1938              
  Lines         88688    88688              
  Branches      13387    13387              
============================================
- Hits          53900    53883      -17     
- Misses        29257    29270      +13     
- Partials       5531     5535       +4     
Flag Coverage Δ
integration-tests-java21 32.38% <100.00%> (+0.01%) ⬆️
integration-tests-java8 32.38% <100.00%> (-0.06%) ⬇️
samples-tests-java21 32.03% <100.00%> (+0.01%) ⬆️
samples-tests-java8 29.68% <100.00%> (-0.05%) ⬇️
unit-tests-java11 59.08% <100.00%> (-0.01%) ⬇️
unit-tests-java17 58.58% <100.00%> (+0.02%) ⬆️
unit-tests-java21 58.56% <100.00%> (-0.01%) ⬇️
unit-tests-java25 58.52% <100.00%> (+0.02%) ⬆️
unit-tests-java8 59.08% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@RainYuY
RainYuY requested review from EarthChen, oxsean and zrlw December 10, 2025 16:50

@zrlw zrlw left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EarthChen EarthChen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EarthChen
EarthChen merged commit efed26c into apache:3.3 Dec 12, 2025
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants