Repository navigation
Fix recognize project packaging by PomUtils - #264
Merged
slawekjaranowski merged 2 commits intoMay 11, 2025
Merged
slawekjaranowski merged 2 commits into
slawekjaranowski merged 2 commits into
Conversation
Member
|
Can you add a unit test for it? |
Check for packaging type pom relies now on child node of project
slawekjaranowski
force-pushed
the
bugfix/ISSUE_263_module_as_not_of_packaging_pom
branch
from
May 11, 2025 20:56
720328a to
f869087
Compare
slawekjaranowski
force-pushed
the
bugfix/ISSUE_263_module_as_not_of_packaging_pom
branch
from
May 11, 2025 20:58
f869087 to
9256f71
Compare
slawekjaranowski
approved these changes
May 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check for packaging type pom relies now on child node of project.
fixes #263
In PomUtils the packagingNode was previously based on the method getElementsByTagName.
But using this method gets every node with name "packaging", not only the packaging node of
the project.
This was corrected by adapting the getModulesNode, changing its name to getModulesNode
and using the parameter name for the node to be returned.
Following this checklist to help us incorporate your
contribution quickly and easily:
Note that commits might be squashed by a maintainer on merge.
This may not always be possible but is a best-practice.
mvn clean verifyto make sure basic checks pass.A more thorough check will be performed on your pull request automatically.
mvn -Prun-its clean verify).If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.