Repository navigation
Add ATR configuration to .asf.yaml - #421
Conversation
|
Please look at https://github.com/apache/maven-script-interpreter/blob/master/.asf.yaml |
|
After merg we need to check if ART produce the same yml |
|
will be conflict with: |
gnodet-bot
left a comment
gnodet-bot
left a comment
There was a problem hiding this comment.
The ATR configuration structure looks correct and the templates/recipients are now in place.
One issue with announce_recipients: all other Apache Maven components consistently use announce@maven.apache.org for that field, not announce@apache.org:
maven-script-interpreter(the reference pointed to by @slawekjaranowski):to: announce@maven.apache.orgmaven-dependency-plugin:to: announce@maven.apache.orgmaven-surefire:to: announce@maven.apache.org
Using announce@apache.org would route release announcements to the global ASF announce list rather than the Maven project list — almost certainly unintended.
This review was generated by an AI agent, Hermès on behalf of @gnodet.
I suggest to fix (by @gnodet) as recommended, then approve/merge. I will rebase 420 if necessary then. If I count days correctly, we could be finished with intended release of 4.0.0-beta-6 until Sunday when I start implementation of apache/maven-sources#57 by merging #420 (otherwise I will postpone). |
Co-authored-by: Slawomir Jaranowski <s.jaranowski@gmail.com>
…nce@maven.apache.org
gnodet-bot
left a comment
gnodet-bot
left a comment
There was a problem hiding this comment.
The announce_recipients issue is fixed — announce@maven.apache.org is now correctly used. Config matches the maven-script-interpreter reference pattern. LGTM.
This review was generated by an AI agent, Hermès on behalf of @gnodet.
The branch-swap prep must carry the current master's .asf.yaml onto the incoming default branch, or ASF asfyaml drops it at the swap. Master gained the full ATR project/policy block in apache#421 after this PR was opened; re-adopt it so the Maven 3 line keeps a correct ATR release config after the switch. Only intended deviation stays the protected-branch rename maven-archiver-3.x -> maven-archiver-4.x. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The branch-swap prep must carry the current master's .asf.yaml onto the incoming default branch, or ASF asfyaml drops it at the swap. Master gained the full ATR project/policy block in #421 after this PR was opened; re-adopt it so the Maven 3 line keeps a correct ATR release config after the switch. Only intended deviation stays the protected-branch rename maven-archiver-3.x -> maven-archiver-4.x. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Add the
project:section to.asf.yamlto enable Apache Trusted Releases (ATR) integration for maven-archiver releases.This follows the same pattern as:
download_path_suffix: shared)download_path_suffix: plugins)With
atr_sync: trueset, ATR will:dist/release/maven/shared/on success